Add notes about default track #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BethGriggs I know there is a list of steps for a new Current but I'm not sure about promotion to LTS. Is there a list for LTS promotion? |
|
If there is a script that handles the release to LTS you could use the CLI ( This would avoid having someone doing the manual release via the webUI. |
|
We could possibly add that to a GitHub Actions script in this repo, we don't currently have snapcraft auth setup from here but I don't imagine that'd be too hard. We'd just need to come up with a strategy for metadata and where this is installed. But tbh it might just be easier if it's part of a manual checklist if the LTS team currently has one - just having an issue opened in this repo should be enough for one of us with access to make the switch. |
https://github.com/nodejs/node/blob/master/doc/guides/releases.md#lts-releases |
richardlau
reviewed
Mar 9, 2021
Co-authored-by: Richard Lau <[email protected]>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Mar 11, 2021
rvagg
added a commit
that referenced
this pull request
Apr 21, 2021
Co-authored-by: Richard Lau <[email protected]>
rvagg
added a commit
that referenced
this pull request
Apr 21, 2021
Co-authored-by: Richard Lau <[email protected]>
rvagg
added a commit
that referenced
this pull request
Apr 21, 2021
Co-authored-by: Richard Lau <[email protected]>
rvagg
added a commit
that referenced
this pull request
Apr 21, 2021
Co-authored-by: Richard Lau <[email protected]>
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Apr 26, 2021
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Apr 26, 2021
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Apr 26, 2021
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 27, 2021
PR-URL: #37708 Refs: nodejs/snap#4 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Apr 29, 2021
PR-URL: #37708 Refs: nodejs/snap#4 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
May 30, 2021
PR-URL: #37708 Refs: nodejs/snap#4 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 5, 2021
PR-URL: #37708 Refs: nodejs/snap#4 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 5, 2021
PR-URL: #37708 Refs: nodejs/snap#4 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
Jun 11, 2021
PR-URL: #37708 Refs: nodejs/snap#4 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tbille of Canonical introduced this functionality to me last year and we pinned it to
12at the time and said we needed to update it when14was our latest LTS .. but that didn't happen because it's a manual thing and needs a human to be on top of it!I've changed it now to
14but I think this might need to be integrated into our procedures for LTS so it gets done properly. I don't know how much set-and-forget explains usage patterns or whether the default track is a big driver of what gets installed, but currently the Node snap is heavily weighted to12. Yesterday's stats have active devices @ 22.5k for12with the next highest being 4.5k for14. Which isn't awesome. It might be worth keeping an eye on how this changes now that the default has been changed.So, I'm wondering if folks currently focusing on LTS have ideas about how to bake this in as a thing that gets done, or we get a reminder at the right time in this repo that it needs to be done? @nodejs/lts