Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CII Silver Badge form responses #1087

Merged
merged 5 commits into from
Jan 4, 2024

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Aug 28, 2023

Main changes

  • Added more elaborated responses for N/A cases
  • Added missing links were needed
  • Solved formatting issues

Context

cc: @rvagg @nodejs/security

@UlisesGascon UlisesGascon changed the title Fix/cii silver Improve CII Silver Badge form responses Aug 28, 2023
@UlisesGascon UlisesGascon marked this pull request as ready for review August 28, 2023 12:42
@@ -91,7 +92,7 @@ The project MUST make an effort to keep the documentation consistent with the cu

The project repository front page and/or website MUST identify and hyperlink to any achievements, including this best practices badge, within 48 hours of public recognition that the achievement has been attained. (URL required)

**Met**
**Met** https://github.com/nodejs/nodejs.org/issues/5432
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temporal reference, until we manage to have the badge in the website 🤔

@@ -313,7 +312,7 @@ https://github.com/nodejs/node/blob/main/doc/contributing/releases.md#11-tag-and

> Hardening mechanisms SHOULD be used in the software produced by the project so that software defects are less likely to result in security vulnerabilities.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what Hardeing mechanisms are in this contect. I don't think it's something that the user can decide though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs: #955 (comment)

I also don't know why this would be up to the end user.

@rvagg
Copy link
Member

rvagg commented Sep 6, 2023

Tried to edit it again to fill some of this in and I'm back to coreinfrastructure/best-practices-badge#1983, I can't edit silver, but I can edit bronze and gold. Will take it back up with them, I've tried different browsers, it doesn't help.

@rvagg
Copy link
Member

rvagg commented Sep 22, 2023

I've figured out a way to update the form and filled in some of the additional pieces added here; still lots of yellow boxes asking for justification though

@github-actions github-actions bot added the stale label Dec 22, 2023
@RafaelGSS RafaelGSS removed the stale label Jan 4, 2024
@RafaelGSS RafaelGSS merged commit 33f2d8a into nodejs:main Jan 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants