Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxstarter asking for my Windows password in a shady PowerShell prompt #439

Closed
Aprillion opened this issue Nov 5, 2018 · 9 comments
Closed
Assignees
Labels

Comments

@Aprillion
Copy link

I just installed Node 10 this weekend and the chockolatey boxstarter started to bother me with Please provide your password so that Boxstarter may automatically log you on. every time I log in.

There is no standard way to uninstall the tool (via Windows Settings or Control Panel), only complicated steps described on https://chocolatey.org/docs/uninstallation

While other malware can show a powershell prompt saying "I am Boxstarter, pleaze gief me your password:", I will assume the message comes from the legit installer because of a valid certificate and no antivirus complaints (yet)..

Could the Node installer please behave better? I.e. not ask me for password days after installation, via a shady prompt in powershell that it asked to be elevated to admin privileges, after an attempt to disable UAC?!?

@lirantal lirantal self-assigned this Nov 5, 2018
@lirantal
Copy link
Member

lirantal commented Nov 5, 2018

Hi @Aprillion,

With regards to your ask about the Node installer this probably isn't the best place to raise your concerns. However, I'm a bit confused whether you are reporting an issue with chockolatey or with Node.js itself but AFAIK the Node.js installer or binary will not prompt you for your password.

Perhaps @nodejs/platform-windows or @nodejs/build might know more.

@refack
Copy link
Contributor

refack commented Nov 5, 2018

Refs: nodejs/node#22645
Refs: nodejs/node#23838
/CC @gep13 @yodurr @joaocgreis

I actually think this issue would be more relevant in nodejs/node and in https://github.com/chocolatey/boxstarter/issues/

P.S.

AFAIK the Node.js installer or binary will not prompt you for your password.

The boxstarter script might (legitimately) ask for your password in order to streamline the install process. IIUC they are reconsidering this behaviur chocolatey/boxstarter#338

@gep13
Copy link

gep13 commented Nov 6, 2018

@Aprillion can you confirm if the Chocolatey/Boxstarter execution completed successfully?

@Aprillion
Copy link
Author

I was able to run choco command as well as node and npm, but I have no idea about boxstarter - I did not provide the password and I uninstalled Chocolatey afterwards. Not sure which Node features will not work because of that ¯_(ツ)_/¯

I reported it here because my security concerns were triggered by the Node installation - if my concerns will be addressed elsewhere, please feel free to close this issue as a duplicate. Thank you for the investigation.

@rvagg
Copy link
Member

rvagg commented Nov 6, 2018

@Aprillion are you saying that you get a cmd window each time you log in to Windows asking for your credentials? And this isn't a one-off thing? Would you mind sharing a screenshot in here for us?

I was under the impression that it was a temporary use of choco just to get stuff done during install, having choco and/or boxstarter persist if you don't have it already on your system is probably not an appropriate thing for the Node installer to be doing.

@gep13
Copy link

gep13 commented Nov 6, 2018

@Aprillion In terms of what Chocolatey and Boxstarter are, I wrote some information in a different issue about this:

chocolatey/boxstarter#357 (comment)

@Aprillion my main question was whether the Boxstarter installation completed successfully, as per this example video where you can see it complete successfully:

https://www.youtube.com/watch?v=gwFpXXIJTvs&t=10s

Or whether you terminated the Boxstarter process while it was happening.

Once the NodeJS installation is complete, Chocolatey and Boxstarter will remain on your machine, however, uninstalling them will not have an impact on the other applications that were installed using them.

@Aprillion
Copy link
Author

Aprillion commented Nov 6, 2018

@rvagg sorry, did not make screenshots

@gep13 now you mention it, I remember I had to turn off the computer while it was hanging in the vctools stage - https://youtu.be/gwFpXXIJTvs?t=7m - so no, it did not complete successfully :(

Glad to hear this is not normal user experience, just an edge case of incomplete installation. In any case, I was surprised that I was receiving the boxstarter prompts on the next day, not from the Node itself about unfinished installation.

Do you recommend to uninstall and re-install Node in this situation or not needed?

@gep13
Copy link

gep13 commented Nov 6, 2018

Forcibly closing the Boxstarter process once it has started has the potential to leave your computer in an unknown state, and as a result, you may see symptoms like you are currently seeing. Things to check would be to do the following:

nodejs/node#23838 (comment)

Then, you may also find that UAC has been disabled on your machine. If this was something you had on before, you may want to re-enable it.

in terms of whether you want to re-install or not, that really depends on what you are doing. The Boxstarter/Chocolatey installation of the tools is something optional, if you require those capabilities. The applications that are attempting to be installed are listed here:

https://github.com/nodejs/node/blob/master/tools/msvs/install_tools/install_tools.txt

You may want to ensure that these tools completed their installation, and if not, run them again. I don't think it will be necessary to uninstall and re-install node itself.

@Aprillion
Copy link
Author

thank you for the help.

nodejs/node#23838 seems like the best place for further discussions if needed, closing this one.

refack added a commit to refack/node that referenced this issue Nov 18, 2018
This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: nodejs#24344
Refs: nodejs#22645
Refs: nodejs#23987
Refs: nodejs/Release#369
Refs: nodejs#23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg pushed a commit to nodejs/node that referenced this issue Nov 28, 2018
This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: #24344
Refs: #22645
Refs: #23987
Refs: nodejs/Release#369
Refs: #23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 29, 2018
This reverts:
	Revision: 257a5e9
	win: add prompt to tools installation script

	Revision: e9a2915
	win: clarify Boxstarter behavior on install tools

	Revision: 3b895d1
	win,msi: display license notes before installing tools

	Revision: cf284c8
	win,msi: install Boxstarter from elevated shell

	Revision: 2b7e18d
	win,msi: highlight installation of 3rd-party tools

	Revision: ebf36cd
	win,msi: install tools for native modules

PR-URL: #24344
Refs: #22645
Refs: #23987
Refs: nodejs/Release#369
Refs: #23838
Refs: nodejs/security-wg#439
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants