require-in-the-middle does not work when using request-promise & request-promise-native

[kirrg001]

Hi there!

I am running into an error when requiring request-promise & request-promise-native.

The request module is used by request-promise and request-promise-native. But require-in-the-middle returns a patched copy of request, which makes it impossible to require request-promise-native.

See https://github.com/request/request-promise-native/blob/master/lib/rp.js#L7
See https://github.com/request/request-promise/blob/master/lib/rp.js#L10

Although request is deprecated, I think this is a general problem with require-in-the-middle when using two libraries, which need a fresh copy of a module.

I have attached a zip, which reproduces the error.

Regards,
Kate

reproduce.zip

[kirrg001]

One option to solve this: instead of returning the cached entry, you could return the original export if the export has changed.

You just need to move this line above the cache check and compare the export results.

const exports = self._origRequire.apply(this, arguments)

As the implementation of Node.js Module.prototype.require (=== Module._load) has it's own internal cache, it doesn't matter if you call the original require or not - see.

You would then check if the export have changed, if yes - return the original export.

[kirrg001]

@trentm I've suggested a solution to the bug report. I can create a bug fix PR if you are okay with it. Thanks

[trentm]

@kirrg001 Sorry for the delay. I've created a PR that fixes this -- at least for the cases that I see, including your "reproduce.zip". Thanks very much for that.