Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔑 Update key for Danielle Adams #5

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

canterberry
Copy link
Collaborator

Supercedes #3.

Per the upstream change nodejs/node#36793.

cc @danielleadams to confirm this is the correct key. I had to pull from keys.openpgp.org, as the STS keyservers are now defunct!

@canterberry canterberry changed the base branch from danielle-adams to master June 29, 2021 00:12
@canterberry
Copy link
Collaborator Author

I'm seeing some spurious changes in this changeset, probably as a result of some unrelated key drift. I'll try to isolate just this one key change and apply a general key update as a separate PR.

@canterberry
Copy link
Collaborator Author

I've reduced the changeset in this MR to only impact @danielleadams 's keys -- both the one used to sign the v15.2.0 release and the currently active one.

This is now ready for review.

@targos
Copy link
Member

targos commented Jun 30, 2021

Do you have a script to automate these updates? Should it be in the repo?

@canterberry
Copy link
Collaborator Author

@targos Yes, and yes! Based the discussion in #6 I've created #8 to enable release signers to update their own keys without a dependency on a third-party keyserver.

@canterberry canterberry merged commit 61d3143 into nodejs:master Jul 2, 2021
@canterberry canterberry deleted the danielle-adams branch July 3, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants