Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] babel's "loose mode" class transform enbrittles BufferList #428

Merged
merged 1 commit into from
Feb 13, 2020
Merged

[Fix] babel's "loose mode" class transform enbrittles BufferList #428

merged 1 commit into from
Feb 13, 2020

Commits on Feb 13, 2020

  1. [Fix] babel's "loose mode" class transform enbrittles BufferList 

    ```js
Object.defineProperty(Object.prototype, util.inspect.custom, {
  set(v) { throw 'this should not happen inside readable-stream'; }
});
```

With this change, I believe the output will use [[Define]] instead of [[Set]] for https://github.com/nodejs/node/blob/c101251a95cc82142bee4637f8db6cc360a06d82/lib/internal/streams/buffer_list.js#L167, and thus no longer fail when Object.prototype is modified.
    @ljharb
    ljharb committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    186503e View commit details
    Browse the repository at this point in the history