Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use safe-buffer #282

Merged
merged 2 commits into from
May 8, 2017
Merged

use safe-buffer #282

merged 2 commits into from
May 8, 2017

Conversation

calvinmetcalf
Copy link
Contributor

see #281

@calvinmetcalf calvinmetcalf requested a review from mcollina May 1, 2017 14:16
mcollina
mcollina approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented May 1, 2017

We need to update https://github.com/rvagg/string_decoder as well.

@calvinmetcalf
Copy link
Contributor Author

rvagg/archived-string_decoder#3

feross
feross approved these changes May 5, 2017
View reviewed changes
Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@calvinmetcalf calvinmetcalf merged commit a449bc8 into master May 8, 2017
@calvinmetcalf calvinmetcalf deleted the safe-buffer branch June 12, 2017 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feross feross feross approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvinmetcalf @mcollina @feross