Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing to see if Array.isArray really is required #214

Closed
wants to merge 1 commit into from

Conversation

calvinmetcalf
Copy link
Contributor

@mcollina
Copy link
Member

It seems fine, LGTM.

@calvinmetcalf
Copy link
Contributor Author

I am somewhat hesitant just that there may be some platforms that we can't test on that it does work enough on but would break if we remove this

@mcollina
Copy link
Member

Let's stick a semver-major label, and we'll merge when we bump the major.
Il giorno lun 23 mag 2016 alle 13:44 Calvin Metcalf <
[email protected]> ha scritto:

I am somewhat hesitant just that there may be some platforms that we can't
test on that it does work enough on but would break if we remove this


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#214 (comment)

@calvinmetcalf
Copy link
Contributor Author

but why should we bother, it's like 3 lines, there is very little upside

@mafintosh
Copy link
Member

I agree with @calvinmetcalf that I dont see the upside in merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants