This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: fix client migration and stream reset #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancel stream buffer after sending reset to avoid segfault
36 tasks
jasnell
force-pushed
the
fix-client-migrate
branch
from
b0d469c
to
4f32e6e
Compare
|
@addaleax @nodejs/quic ... with this PR, all current tests are passing locally on Windows. It would be excellent to get some confirmation across platforms tho
|
jasnell
force-pushed
the
fix-client-migrate
branch
from
4f32e6e
to
f72a03a
Compare
addaleax
approved these changes
Feb 12, 2020
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
cancel stream buffer after sending reset to avoid segfault PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
jasnell
added a commit
that referenced
this pull request
Feb 12, 2020
PR-URL: #341 Reviewed-By: Anna Henningsen <[email protected]>
|
Landed!! As of right this moment, all current QUIC tests are passing! Woo! |
jasnell
added a commit
to nodejs/node
that referenced
this pull request
Feb 17, 2020
If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: #31756 Refs: nodejs/quic@b0d469c Refs: nodejs/quic#341 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 27, 2020
If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: #31756 Refs: nodejs/quic@b0d469c Refs: nodejs/quic#341 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 15, 2020
If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: #31756 Refs: nodejs/quic@b0d469c Refs: nodejs/quic#341 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 17, 2020
If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: #31756 Refs: nodejs/quic@b0d469c Refs: nodejs/quic#341 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 30, 2020
If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: #31756 Refs: nodejs/quic@b0d469c Refs: nodejs/quic#341 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two tests