Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

quic: additional cleanups and fixups #294

Closed
wants to merge 8 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 22, 2020

No description provided.

src/quic/node_quic_session.h Outdated Show resolved Hide resolved
src/quic/node_quic_socket.cc Show resolved Hide resolved
src/quic/node_quic_socket.h Outdated Show resolved Hide resolved
src/quic/node_quic_stream.h Outdated Show resolved Hide resolved
src/quic/node_quic_stream.h Outdated Show resolved Hide resolved
src/quic/node_quic_stream.h Outdated Show resolved Hide resolved
src/quic/node_quic_util.h Outdated Show resolved Hide resolved
src/quic/node_quic_util.h Show resolved Hide resolved
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is a bit nicer than the double-template approach :)

@jasnell jasnell force-pushed the additional-cleanup-jan22 branch 2 times, most recently from 9e495d4 to 5903361 Compare January 23, 2020 14:36
jasnell added a commit that referenced this pull request Jan 23, 2020
PR-URL: #294
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Jan 23, 2020
PR-URL: #294
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Jan 23, 2020
jasnell added a commit that referenced this pull request Jan 23, 2020
PR-URL: #294
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Jan 23, 2020
Fixes: #65
PR-URL: #294
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit that referenced this pull request Jan 23, 2020
jasnell added a commit that referenced this pull request Jan 23, 2020
jasnell added a commit that referenced this pull request Jan 23, 2020
PR-URL: #294
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Jan 23, 2020

Landed

@jasnell jasnell closed this Jan 23, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
Fixes: nodejs#65
PR-URL: nodejs#294
Reviewed-By: Anna Henningsen <[email protected]>
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
jasnell added a commit to jasnell/quic that referenced this pull request Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants