chore: add CPU pinning #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Apr 8, 2024
| @@ -101,7 +101,7 @@ fi | |||
| fileName=output`date +%d%m%y-%H%M%S`.csv | |||
| echo "Output will be saved to $fileName" | |||
| pwd | |||
| ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName | |||
| ./node-master benchmark/compare.js --set CPUSET=0 --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName | |||
There was a problem hiding this comment.
I'm not sure CPUSET=0 is the desired setting -- wouldn't this set the benchmarks to only run on CPU 0?
There was a problem hiding this comment.
nodejs/node#52233 (comment) suggests
So it should just be a matter of
taskset -c 0-11 <command>for the perf cores.
So maybe CPUSET=0-11? Or perhaps a better approach would be to parameterize (similar to e.g. $FILTER, $RUNS, etc.) and then we can set the parameter in Jenkins.
rluvaton
added a commit
that referenced
this pull request
Apr 8, 2024
rluvaton
added a commit
that referenced
this pull request
Apr 8, 2024
* Run on CPUs 0-11 (perf cores) Ref: #157 (comment) * add option to run on specific cpu set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/build#3657 (comment)