Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Charter #592

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add Charter #592

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 28, 2024

Not sure if we actually need that, or if this is the right approach. The idea would be to delegate the discussions from TSC meetings to a different group.


[README.md]: ./README.md#current-project-team-members

### Version Management Tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For folks seeing such a large diff and wondering what changed, this is the section to focus on. The rest is marked as changed but really isnt. Additionally, the parts above about the repo's is because the goal here is to subsume the corepack team into the PMWG.

@wesleytodd
Copy link
Member

Goals of this change:

  1. Give discussions around package managers of all varieties a place to have dedicated discussions around how they interop with Node.js (both the technical and the non-technical)
  2. Avoid Node.js Core PRs being the only avenue for having active discussion on these topics (avoid battle pr's deps: remove corepack node#51981 and build: enable yarn and pnpm Corepack binaries by default node#51886 for example)
  3. Help give more resources to @GeoffreyBooth's work to help define Node.js policy around this stuff
  4. Make it unambiguous where to seek consensus for future discussions before raising related topics to Node.js core or TSC

Governance.md Outdated Show resolved Hide resolved

The WG responsibilities include:

* Management of the "version management tools" shipped with the Node.js distribution (see below).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure whether whatever potential new tool we make would necessarily ship bundled in the distribution; and of course we might unbundle Corepack. We should still be responsible for these things regardless, though, so I think a better way to put it is that we’re responsible for anything under https://github.com/nodejs.

Suggested change
* Management of the "version management tools" shipped with the Node.js distribution (see below).
* Management of the version management tools” maintained within the Node.js GitHub org.

Copy link
Member

@wesleytodd wesleytodd Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting point. Hm, yeah I think this is a good goal of this change but npm is not maintained within this org, so that feels at odds right?


The WG has authority over Version Management solutions in the project including:

* Maintaining the relationship[^note] with any tools included in the Node.js default distribution with the express purpose of the following:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Maintaining the relationship[^note] with any tools included in the Node.js default distribution with the express purpose of the following:
* Maintaining the relationship[^note] with any tools included or referenced by Node.js-managed software with the express purpose of the following:

* Maintaining the relationship[^note] with any tools included in the Node.js default distribution with the express purpose of the following:
- Download or install additional software from sources outside the default distribution.
- Download or install additional Node.js distributions (default or third-party).
* Contribution policy for all of the additional software included in the Node.js distribution as qualified above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Contribution policy for all of the additional software included in the Node.js distribution as qualified above.
* Contribution policy for all of the additional software within the Node.js GitHub organization as qualified above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm interesting change. I think I understand why but would you mind explaining the goal of this wording over the other?

Co-authored-by: Geoffrey Booth <[email protected]>
@GeoffreyBooth
Copy link
Member

In the collab summit meeting meeting on 2024-04-03 we discussed trying to agree on goals first, and getting those approved by both this team and then the TSC, and then chartering this team to work out the implementation details to achieve those goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants