-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
meta: upgrade to next.js 16 #8218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
5ad8a08
8083835
e70ef55
12a688d
f6a22c8
7bb089a
67047d3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ package-lock.json | |
| # Next.js Build Output | ||
| .next | ||
| build | ||
| next-env.d.ts | ||
|
|
||
| # Test Runner | ||
| junit.xml | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
| /// <reference types="next/navigation-types/compat/navigation" /> | ||
| /// <reference path="./.next/types/routes.d.ts" /> | ||
| import "./.next/types/routes.d.ts"; | ||
avivkeller marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/app/api-reference/config/typescript for more information. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,8 @@ import { redirects, rewrites } from './next.rewrites.mjs'; | |
|
|
||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = { | ||
| allowedDevOrigins: ['10.1.1.232'], | ||
| // Full Support of React 18 SSR and Streaming | ||
| reactCompiler: true, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need to remove it, now. Eventually we could run a React Compiler Codemod? Like https://app.codemod.com/registry/react/19/remove-memoization |
||
| // We don't want to redirect with trailing slashes | ||
| skipTrailingSlashRedirect: true, | ||
| // We allow the BASE_PATH to be overridden in case that the Website | ||
|
|
@@ -75,10 +76,7 @@ const nextConfig = { | |
| // Enable statically typed links | ||
| // @see https://nextjs.org/docs/app/api-reference/config/typescript#statically-typed-links | ||
| typedRoutes: true, | ||
| // We don't want to run ESLint Checking on Production Builds | ||
| // as we already check it on the CI within each Pull Request | ||
| // we also configure ESLint to run its lint checking on all files | ||
| eslint: { ignoreDuringBuilds: true }, | ||
| // Experimental Flags | ||
| experimental: { | ||
| useCache: true, | ||
| // Ensure that server-side code is also minified | ||
|
|
@@ -105,6 +103,8 @@ const nextConfig = { | |
| 'tailwindcss', | ||
| 'shiki', | ||
| ], | ||
| // Faster Development Servers with Turbopack | ||
| turbopackFileSystemCacheForDev: true, | ||
| }, | ||
| // If we're building for the Cloudflare deployment we want to set | ||
| // an appropriate deploymentId (needed for skew protection) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,17 +3,17 @@ | |
| "type": "module", | ||
| "scripts": { | ||
| "prebuild": "node --run build:blog-data", | ||
| "build": "node --run build:default -- --turbo", | ||
| "build": "node --run build:default -- --turbopack", | ||
| "build:blog-data": "cross-env NODE_NO_WARNINGS=1 node ./scripts/blog-data/generate.mjs", | ||
| "build:blog-data:watch": "node --watch --watch-path=pages/en/blog ./scripts/blog-data/generate.mjs", | ||
| "build:default": "cross-env NODE_NO_WARNINGS=1 next build", | ||
| "cloudflare:build:worker": "OPEN_NEXT_CLOUDFLARE=true opennextjs-cloudflare build", | ||
| "cloudflare:deploy": "opennextjs-cloudflare deploy", | ||
| "cloudflare:preview": "wrangler dev", | ||
| "predeploy": "node --run build:blog-data", | ||
| "deploy": "cross-env NEXT_PUBLIC_STATIC_EXPORT=true node --run build:default -- --turbo", | ||
| "deploy": "cross-env NEXT_PUBLIC_STATIC_EXPORT=true node --run build:default -- --turbopack", | ||
| "predev": "node --run build:blog-data", | ||
| "dev": "cross-env NODE_NO_WARNINGS=1 next dev --turbo", | ||
| "dev": "cross-env NODE_NO_WARNINGS=1 next dev --turbopack", | ||
| "lint": "node --run lint:js && node --run lint:css && node --run lint:md", | ||
| "lint:fix": "node --run lint:js:fix && node --run lint:css:fix && node --run lint:md:fix", | ||
| "lint:css": "stylelint \"**/*.css\" --allow-empty-input --cache --cache-strategy=content --cache-location=.stylelintcache", | ||
|
|
@@ -60,7 +60,7 @@ | |
| "github-slugger": "~2.0.0", | ||
| "gray-matter": "~4.0.3", | ||
| "mdast-util-to-string": "^4.0.0", | ||
| "next": "15.5.4", | ||
| "next": "16.0.0", | ||
| "next-intl": "~4.3.11", | ||
| "next-themes": "~0.4.6", | ||
| "postcss-calc": "~10.1.1", | ||
|
|
@@ -81,16 +81,17 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@flarelabs-net/wrangler-build-time-fs-assets-polyfilling": "^0.0.1", | ||
| "@next/eslint-plugin-next": "15.5.4", | ||
| "@next/eslint-plugin-next": "16.0.0", | ||
| "@node-core/remark-lint": "workspace:*", | ||
| "@opennextjs/cloudflare": "^1.6.4", | ||
| "@playwright/test": "^1.54.1", | ||
| "@testing-library/user-event": "~14.6.1", | ||
| "@types/mdast": "^4.0.4", | ||
| "@types/mdx": "^2.0.13", | ||
| "@types/semver": "~7.7.1", | ||
| "babel-plugin-react-compiler": "^1.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need to include this dep on a dependabot group ? Maybe the react one There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, why not. |
||
| "dedent": "^1.6.0", | ||
| "eslint-config-next": "15.5.4", | ||
| "eslint-config-next": "16.0.0", | ||
| "eslint-plugin-mdx": "~3.6.2", | ||
| "eslint-plugin-react": "~7.37.5", | ||
| "eslint-plugin-react-hooks": "^5.2.0", | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is that and why ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please read the previous PR comments lol There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw there are an issue on the building of 404 pages. But why include it on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please read the previous PR comments. Do due diligence before reviewing a PR 🙇 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export default () => null; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export default () => null; | ||
ovflowd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not use these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to remove this as it ironically forces this component to be client-side only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can we remove the
use client?