Skip to content

fix: remove confusing close label for navigation menu #7463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 2 commits into from
Feb 11, 2025
Merged

fix: remove confusing close label for navigation menu #7463

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7c906
fix: remove confusing close label for navigation menu
aduh95 Feb 1, 2025
9066397
use `toggle`
aduh95 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/site/components/Containers/NavBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,7 @@ const NavBar: FC<NavbarProps> = ({
id="sidebarItemToggler"
type="checkbox"
onChange={e => setIsMenuOpen(() => e.target.checked)}
aria-label={t(
`components.containers.navBar.controls.${isMenuOpen ? 'close' : 'open'}`
)}
aria-label={t(`components.containers.navBar.controls.open`)}
Comment thread
aduh95 marked this conversation as resolved.
Outdated
/>

<div className={`${style.main} peer-checked:flex`}>
Expand Down
3 changes: 1 addition & 2 deletions packages/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
},
"navBar": {
"controls": {
"open": "Show navigation menu",
"close": "Close navigation menu"
"open": "Show navigation menu"
Comment thread
aduh95 marked this conversation as resolved.
Outdated
},
"links": {
"about": "About",
Expand Down