-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align mdx #7276
fix: align mdx #7276
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment has been minimized.
This comment has been minimized.
fae50cb
to
9cd4a93
Compare
Requesting fast-tracking! cc @nodejs/nodejs-website |
Lighthouse Results
|
@ovflowd if these were passing lint before, is that indicative that we were not linting/formatting them, or ??? i dont want another crowdin sync to clobber all this, or rather, if the whitespace is unimportant, why fix it |
This has nothing to do with linting. It is a prettier bug. Linting-wise both are valid. |
🤷 -- afaik my changes will override that. |
interesting, we call prettier directly within https://github.com/nodejs/nodejs.org/blob/main/.github/workflows/translations-pr.yml#L116-L119 instead of using our |
Follow-up issue to investigate that? |
FYI here's the master issue for MDXv3 for prettier: prettier/prettier#12209 |
This PR realigns all
index.mdx
files from all languages. Note that there might be other MDX files with discrepancies too 🤷