Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mastodon.tsx): replace old mastodon icon with new icon #6860

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

liberaldev
Copy link
Contributor

@liberaldev liberaldev commented Jun 23, 2024

Description

Replace the old logo of the mastodon with the new logo.

Validation

스크린샷 2024-06-23 225129

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@liberaldev liberaldev requested a review from a team as a code owner June 23, 2024 13:54
Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 15, 2024 9:01am

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@AugustinMauroy
Copy link
Member

For your information https://joinmastodon.org/en/branding

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !
Thanks for your first contribution !

@bmuenzenmeyer
Copy link
Collaborator

This PR will need to be rebased or recreated now that #6850 merged.

Copy link

Unit Test Coverage Report

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.273s ⏱️

@mikeesto
Copy link
Member

mikeesto commented Jul 15, 2024

I've rebased this in the interests of getting it merged soon

It looks like the UI change will need to be approved in Chromatic

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2024
@mikeesto mikeesto added this pull request to the merge queue Jul 17, 2024
Merged via the queue into nodejs:main with commit b09d9aa Jul 17, 2024
14 checks passed
@liberaldev liberaldev deleted the change-mastodon-icon branch July 22, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants