Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed misleading info #6855

Closed
wants to merge 0 commits into from
Closed

fix: Removed misleading info #6855

wants to merge 0 commits into from

Conversation

Wellitsabhi
Copy link
Contributor

Description

Removed the misleading info as mentioned in issue #6853

Validation

image

Related Issues

Fixes: #6853

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Wellitsabhi Wellitsabhi requested a review from a team as a code owner June 21, 2024 13:36
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 7, 2024 4:29am

@TenzDelek
Copy link
Contributor

@Wellitsabhi I think reverting the changes directly from the merged PR page will be a better choice for clarity and consistency rather than merging a new PR with a manual revert might create unnecessary changes.

@Wellitsabhi
Copy link
Contributor Author

I agree but I don't have access to perform reverts, also @ovflowd might have put some thought before allowing to raise PR.

@bmuenzenmeyer
Copy link
Collaborator

I don't follow why this approach would be bad. Don't worry about it. Clean git history is overrated.

That said, we're not meeting anything until monorepo conversion stabilizes.

@TenzDelek
Copy link
Contributor

I don't follow why this approach would be bad. Don't worry about it. Clean git history is overrated.

That said, we're not meeting anything until monorepo conversion stabilizes.

Can't agree more on this, :)

@bmuenzenmeyer
Copy link
Collaborator

This PR will need to be rebased or recreated now that #6850 merged.

@Wellitsabhi
Copy link
Contributor Author

I really don't understand how it got closed, i shall be adding new PR again.

@Wellitsabhi
Copy link
Contributor Author

@bmuenzenmeyer i recreated this PR as #6924
and would like to request review on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading debugging information: "Node.js and the Chrome need to be run on the same platform"
3 participants