-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove reference to outdated examples #6851
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking until nodejs/admin#883 is resolved
Thanks! I wanted this blocked until that's resolved anyway, but I wanted to put it in the works to make sure it's okay dev-wise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is now unblocked due to the resolution of the other issue - but we wont merge until we solidify monorepo work
This PR will need to be rebased or recreated now that #6850 merged. |
Done! |
Lighthouse Results
|
Unit Test Coverage ReportUnit Test Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
Description
This PR removes the reference to the outdated example repository, as in its current state, it may confuse users more than help them.
Related Issues
nodejs/admin#883 discusses archiving the repository, and this is the only actively maintained link to the repository.
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.