feat: introduced generic time component #5497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
|
@mikeesto I've made a clean PR (just because I accidentally deleted the branch on upstream) (Actually, this branch should have been done on the fork to begin with... but hey, Codespaces default remote was set to upstream) |
ovflowd
changed the title
Contributor
📦 Next.js Bundle Analysis for nodejs.orgThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mikeesto
approved these changes
Jul 11, 2023
Member
mikeesto
left a comment
mikeesto
left a comment
There was a problem hiding this comment.
Not sure why there is a diff for package-lock? Otherwise LGTM.
aymen94
approved these changes
Jul 11, 2023
Member
Author
A little audit fix |
umairraza96
pushed a commit
to umairraza96/nodejs.org
that referenced
this pull request
Jul 12, 2023
Co-authored-by: Michael Esteban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a simple
Timecomponent that fulfils the specification presented on the issue.It also updates the
enlocale to useen-GBRelated Issues
Fixes #5481