Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 10, 2023

This PR fixes the current structure of the pull-request.yml GitHub Actions Workflow by creating a dedicated Workflow for Build & Analysis.

This allows us to do builds on main and any Pull Request. This also fixes the issue that the Bundle Analysis are never happening on main, causing the bundle analysis to be ineffective.

@ovflowd ovflowd added github_actions fast-track Fast Tracking PRs labels Jul 10, 2023
@ovflowd ovflowd requested a review from a team as a code owner July 10, 2023 14:46
@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 3:14pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 3:14pm

@ovflowd
Copy link
Member Author

ovflowd commented Jul 10, 2023

cc @website as I need an urgent fast track over here.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 14:47 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 15:13 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 15:14 Inactive
@ovflowd ovflowd merged commit 2208a72 into nodejs:main Jul 10, 2023
@ovflowd ovflowd deleted the fix/dispatch-workflows branch July 10, 2023 15:15
umairraza96 pushed a commit to umairraza96/nodejs.org that referenced this pull request Jul 10, 2023
umairraza96 pushed a commit to umairraza96/nodejs.org that referenced this pull request Jul 10, 2023
umairraza96 pushed a commit to umairraza96/nodejs.org that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant