fix: Windows-rendering of content #5476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
reviewed
Jul 6, 2023
ovflowd
reviewed
Jul 6, 2023
ovflowd
approved these changes
Jul 6, 2023
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
Let's ensure on Linux and macOS; this is working as expected.
We probably in the future should unit test this with examples of how each OS would handle paths.
Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]>
aymen94
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd hadn't clicked around the site locally on my Windows machine in a bit, instead only rendering the homepage. The homepage was rendering fine, but every other page was 404ing content due to Windows pathing. I fixed this in two cases, indexes and deeper paths.
Validation
All of these pages should continue to render for you locally.
Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing, and/ornpx turbo test:snapshotto update snapshots if I created and/or updated React Components.