chore: new constants and better analytics #5475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovflowd
added
bug
fast-track
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bmuenzenmeyer
approved these changes
Jul 6, 2023
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
can you provide a link to the RSS feed? I cannot quickly find it and am surprised it's not visible on the UI from a quick glance
Member
Author
It's available on the "view-source" as part of the head. But quick link is https://nodejs.org/en/feed/blog.xml |
Signed-off-by: Claudio Wunder <[email protected]>
Member
Author
|
I'm fast-tracking this @nodejs/website |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new Environment Variables that allow us both during build-time and runtime to evaluate if the Application is running under Vercel, which allows us to render the Vercel Analytics component conditionally.
This PR also introduces a
BASE_URLconstant that allows us to add on URLs that before were manually (hard-coded) defined ashttps://nodejs.org.This PR also fixes the RSS Feed not having the Base URL as a prefix and the Canonical URL being the wrong route on
HtmlHeadcomponent.