feat: better separation of mdx content and headings support #5467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
added
website redesign
Member
Author
|
cc @nodejs/website for reviews |
Harkunwar
approved these changes
Jul 2, 2023
bmuenzenmeyer
requested changes
Jul 3, 2023
Contributor
bmuenzenmeyer
left a comment
bmuenzenmeyer
left a comment
There was a problem hiding this comment.
only had time for a quick read - couldn't run the code yet.
one npm nit and one import lint nit
aymen94
approved these changes
Jul 4, 2023
Member
Author
|
It looks like Storybook broke with Next.js 13.4.8: storybookjs/storybook#23287 |
Member
Author
|
I'm downgrading Next.js back to 13.4.7 on this PR for the meantime. |
bmuenzenmeyer
approved these changes
Jul 4, 2023
Member
Author
|
Storybook fixed their bug, we can upgrade to Next.sj 13.4.8 https://github.com/storybookjs/storybook/releases/tag/v7.0.26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a better separation of the
MDXRemoteprops on thenext.dynamic.mjsgeneration; It introduces support to theVFilemetadata through theunifiedpipeline, which can be used for the Remark Plugins that mutate theVFilemeta, such asremark-frontmatter,remark-headings.And ultimately does a better separation of the
theme.tsxwith themdxProvidercontent.Lastly, it adds support to Headings for the TOC generation through
remark-headings