-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: provided some file structural changes #5464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Harkunwar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
cc @nodejs/website requesting fast-tracking here as some of these changes would benefit from being deployed soonish. |
|
Read through it too, look good. The sanitization is a bit concerning for long term consideration, in case remote markdown is ever used. |
@bmuenzenmeyer agreed. But to be fair, all the Components with manual unsafe injection of HTML will be removed once we migrate to the new Components. But I would probably also avoid at all costs on actually using remote markdown, even tho we do use |
apologies, I feel as if I keep bringing up things the team has already thought through 😄 |
Description
This PR does some minimal changes meant to improve the build experience and reduce the performance costs.
helpers.mjsintonext.helpers.mjsas they're not exclusive tonext-datanext-data/index.mjsto justnext.data.mjsswcfrom the output tracinghighlight.jsis going to be removed once we get rid of the legacy pagesThemeComponent by disabling unnecessary re-rendersprecommithook by simply usinggit checkoutprebuild