fix(package.json): Fix collision during commit. #5463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
approved these changes
Jul 2, 2023
ovflowd
approved these changes
Jul 2, 2023
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
LGTM! (nevermind my previous comment)
Contributor
|
This change and other recent ones make me wonder if we can integrate prettier fully into eslint via eslint-plugin-prettier. I'll open an issue |
Member
Doesn't prettier themselves discourage that practice? |
Contributor
Oh, interesting! I'd love to learn more about that. I've successfully used this configuration for a while now. I think the conversation can be better resolved in #5466 however so as to not pollute this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many times when I try to run commit, it fails because both
lint:fixandprettier:fixare trying to write to the same file at the same time. These should not be run concurrently, so made this change to run them sequentially.Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing, and/ornpx turbo test:snapshotto update snapshots if I created and/or updated React Components.