Skip to content

feat: new i18n engine/locale system - #5397

Merged
aymen94 merged 7 commits into
nodejs:mainfrom
ovflowd:feat/new-locale-system
May 31, 2023
Merged

feat: new i18n engine/locale system#5397
aymen94 merged 7 commits into
nodejs:mainfrom
ovflowd:feat/new-locale-system

Conversation

@ovflowd

@ovflowd ovflowd commented May 24, 2023

Copy link
Copy Markdown
Member

This PR introduces a refactor of the i18n/Internationalisation Engine we use within the Website.

Major Changes

  • Localisation Data is not appended to pageProps anymore
  • All Translations are part of the bundle now
    • This decreases the size of the bundle (pageProps) by only having one copy of the translations
  • Faster build time by reducing pre-build/during-build/transform logic
  • The Next Router calculates localization and is always available
  • Centralized Localization Engine next.locales.mjs
  • Better Locale handling
  • Merge Default Translation Messages with Translated ones (to fallback when not available)
  • Cleaner code for the Internationalisation Engine

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes
@aymen94 aymen94 aymen94 approved these changes
@mikeesto mikeesto mikeesto approved these changes
+2 more reviewers
@rodion-arr rodion-arr rodion-arr approved these changes
@shanpriyan shanpriyan shanpriyan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ovflowd @rodion-arr @aymen94 @mikeesto @shanpriyan @AugustinMauroy