Skip to content

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented May 17, 2023

No description provided.

Harkunwar and others added 10 commits May 5, 2023 10:09
Co-authored-by: Manish Kumar ⛄ <[email protected]>
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Michael Esteban <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <[email protected]>
Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: Guilherme Araújo <[email protected]>
Co-authored-by: Augustin Mauroy <[email protected]>
Co-authored-by: HinataKah0 <[email protected]>
Co-authored-by: Olaleye Blessing <[email protected]>
Co-authored-by: ktssr <[email protected]>
Co-authored-by: vasanthkumar <[email protected]>
Co-authored-by: Floran Hachez <[email protected]>
Co-authored-by: Jatin <[email protected]>
fixed styleling misconfig and fixed storybooks (#5281)
fix storybook styles, imports, typescript config and dependencies (#5319
fix(package.json) Lint command is missing slashes (#5321
fix storybook local development mode (#5335)
fix(i18n): translation key (#5347)
… method (#5369)

Add clarity to step 4 based on clone method

Signed-off-by: Vessy Shestorkina <[email protected]>
* Migrate JsonLink component

Signed-off-by: Vessy Shestorkina <[email protected]>

* Add storybook snap and robot icon

Signed-off-by: Vessy Shestorkina <[email protected]>

* Remove IconContext provider

Signed-off-by: Vessy Shestorkina <[email protected]>

---------

Signed-off-by: Vessy Shestorkina <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink

* refactor(useDownloadLink): rename file

* refactor(useDownloadLink): rename file

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <[email protected]>

* refactor(useDownloadLink): undo deleted file

---------

Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
* feat: Add MUI Config and Theme Provider

* added createTheme

* refactor themeConfig

* feat(theme): Fix linting and package-lock

* feat(theme): Add emotion styled and emtion react

---------

Co-authored-by: Harkunwar Kochar <[email protected]>
refactor(test): Delete duplicate test file

Co-authored-by: Claudio Wunder <[email protected]>
* feat(useClickOutside): introduce

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* feat(useClickOutside): fix and twix

* feat(dropdown): remove useless ref

* feat(useClickOutside): update unit test

* feat(UseClickOutside): update type

* fix: usage of type

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* update listener

* Update components/Common/LanguageSelector/index.tsx

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: languageSelector

* update with feedback

* better unit test

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* feat(useClickOutside): update with feedback

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: if click on modal

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Signed-off-by: Harkunwar Kochar <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update useClickOutside.ts

* Update hooks/useClickOutside.ts

Co-authored-by: Shanmughapriyan S <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update useClickOutside.ts

* Apply suggestions from code review

Signed-off-by: Claudio Wunder <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* Update hooks/useClickOutside.ts

Co-authored-by: Claudio Wunder <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>

* fix: build

---------

Signed-off-by: Augustin Mauroy <[email protected]>
Signed-off-by: Harkunwar Kochar <[email protected]>
Signed-off-by: Claudio Wunder <[email protected]>
Co-authored-by: Claudio Wunder <[email protected]>
Co-authored-by: Shanmughapriyan S <[email protected]>
Co-authored-by: Harkunwar Kochar <[email protected]>
@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 5:57pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 17, 2023 5:57pm

@ovflowd ovflowd merged commit 2065bf7 into main May 17, 2023
@ovflowd
Copy link
Member Author

ovflowd commented May 17, 2023

This PR got forced-updated as we just want to update the main branch with latest of major/website-redesign.

@ovflowd
Copy link
Member Author

ovflowd commented May 17, 2023

cc @nodejs/website that the major/website-redesign branch got updated. (But this time with a merge strategy instead of rebase) which should not affect your work.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 17, 2023 17:52 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 17, 2023 17:57 Inactive
@ovflowd
Copy link
Member Author

ovflowd commented May 17, 2023

I reverted this PR as I've forgot that a squash commit would hinder our history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants