-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Ada to the dependencies page #5185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is very incomplete. Higher-impact dependencies such as undici and nghttp2 are not listed either. I am not sure what subset of dependencies makes sense here, or if this page provides value at all in its current state.
@tniessen the page is just super outdated. But would love if it can be updated with all the new stuff :D |
I'm not sure this page adds value for the average user. I wonder if it should be ported to a README for the |
None of this is an objection to updating the page to reflect current-ish information though. |
That's correct, @Trott. We can close this PR and pivot to doing something on Meaning even if we add this now, as we agreed that the .dev pages replace the .org ones, it will be removed very prematurely. @anonrig do you think you can pivot such kind of change on |
Co-authored-by: Rich Trott <[email protected]> Signed-off-by: Yagiz Nizipli <[email protected]>
Co-authored-by: Rich Trott <[email protected]> Signed-off-by: Yagiz Nizipli <[email protected]>
@Trott Even though, I agree with your concerns, this particular recommendation will lead to outdated commit URL in this page too. If we are going this path, I think we should include the dependencies and distribute it with the Node.js documentation (which is version specific). (I didn't had any chance to look into the documentation tools & infrastructure. I don't know the depth or possibility of this task, therefore my assumption/recommendation might be invalid.)
@Trott I recommend merging this pull request, and later discuss the future of this document in a separate PR or an issue for wider visibility.
@ovflowd If this is the case, we should remove those documents from Crowdin. A lot of people are investing their own time to translate these soon-to-be-removed documents, and if we are simply not use them in the future, we should suspend all translation activities.
@ovflowd As a non-native English speaker, I think there are more qualified people who can do this faster & cleaner than me. |
@anonrig Ive made an announcement on Crowdin several days ago asking people to no translate the current content as it's going to be 100% discarded 🙈 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
I'd be happy to draft this up! |
I was about to propose a new README at Taking @Trott's words here as a guiding set of principles, this file seems to have everything we would want:
|
I think we should delete this page and make the link on navigation to simply redirect to the Markdown file on core. |
The current dependencies list is not up to date. The following changes only updates
Ada
, Node.js's new URL parser.