Skip to content

chore(next/link): do not use link for external links #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 2 commits into from
Mar 13, 2023
Merged

chore(next/link): do not use link for external links #5106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a67888
chore(next/link): do not use link for external links
ovflowd Mar 12, 2023
14693d0
Merge branch 'main' into chore/no-next-link-for-external-links
Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 18 additions & 24 deletions components/Docs/NodeApiVersionLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,59 @@
import Link from 'next/link';

// Note.: This is a temporary Component used only until the transition to `nodejs/nodejs.dev` content is done
const NodeApiVersionLinks = () => (
<ul>
<li>
<Link href="https://nodejs.org/docs/latest-v19.x/api/">Node.js 19.x</Link>
<a href="https://nodejs.org/docs/latest-v19.x/api/">Node.js 19.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v18.x/api/">Node.js 18.x</Link>
<a href="https://nodejs.org/docs/latest-v18.x/api/">Node.js 18.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v17.x/api/">Node.js 17.x</Link>
<a href="https://nodejs.org/docs/latest-v17.x/api/">Node.js 17.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v16.x/api/">Node.js 16.x</Link>
<a href="https://nodejs.org/docs/latest-v16.x/api/">Node.js 16.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v15.x/api/">Node.js 15.x</Link>
<a href="https://nodejs.org/docs/latest-v15.x/api/">Node.js 15.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v14.x/api/">Node.js 14.x</Link>
<a href="https://nodejs.org/docs/latest-v14.x/api/">Node.js 14.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v13.x/api/">Node.js 13.x</Link>
<a href="https://nodejs.org/docs/latest-v13.x/api/">Node.js 13.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v12.x/api/">Node.js 12.x</Link>
<a href="https://nodejs.org/docs/latest-v12.x/api/">Node.js 12.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v11.x/api/">Node.js 11.x</Link>
<a href="https://nodejs.org/docs/latest-v11.x/api/">Node.js 11.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v10.x/api/">Node.js 10.x</Link>
<a href="https://nodejs.org/docs/latest-v10.x/api/">Node.js 10.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v9.x/api/">Node.js 9.x</Link>
<a href="https://nodejs.org/docs/latest-v9.x/api/">Node.js 9.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v8.x/api/">Node.js 8.x</Link>
<a href="https://nodejs.org/docs/latest-v8.x/api/">Node.js 8.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v7.x/api/">Node.js 7.x</Link>
<a href="https://nodejs.org/docs/latest-v7.x/api/">Node.js 7.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v6.x/api/">Node.js 6.x</Link>
<a href="https://nodejs.org/docs/latest-v6.x/api/">Node.js 6.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v5.x/api/">Node.js 5.x</Link>
<a href="https://nodejs.org/docs/latest-v5.x/api/">Node.js 5.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v4.x/api/">Node.js 4.x</Link>
<a href="https://nodejs.org/docs/latest-v4.x/api/">Node.js 4.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v0.12.x/api/">
Node.js 0.12.x
</Link>
<a href="https://nodejs.org/docs/latest-v0.12.x/api/">Node.js 0.12.x</a>
</li>
<li>
<Link href="https://nodejs.org/docs/latest-v0.10.x/api/">
Node.js 0.10.x
</Link>
<a href="https://nodejs.org/docs/latest-v0.10.x/api/">Node.js 0.10.x</a>
</li>
</ul>
);
Expand Down
7 changes: 3 additions & 4 deletions components/Downloads/DownloadList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { FormattedMessage } from 'react-intl';
import Link from 'next/link';

import LocalisedLink from '../LocalisedLink';
import { useNavigation } from '../../hooks/useNavigation';
Expand All @@ -23,9 +22,9 @@ const DownloadList = (props: DownloadListProps) => {
<li key={key}>
<LocalisedLink href={item.link}>{item.text}</LocalisedLink>
{item.key === 'shaSums' && (
<Link href="https://github.com/nodejs/node#verifying-binaries">
<FormattedMessage id="components.downloadList.links.shaSums.howToVerify" />
</Link>
<a href="https://github.com/nodejs/node#verifying-binaries">
<FormattedMessage id="components.downaloadList.links.shaSums.howToVerify" />
</a>
)}
</li>
))}
Expand Down
12 changes: 6 additions & 6 deletions components/Downloads/DownloadReleasesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ const DownloadReleasesTable = ({ releases }: DownloadReleasesTableProps) => (
<td data-label="npm">{release.npm}</td>
<td data-label="NODE_MODULE_VERSION">{release.modules}</td>
<td className="download-table-last">
<Link href={`https://nodejs.org/download/release/${release.node}`}>
<a href={`https://nodejs.org/download/release/${release.node}`}>
<FormattedMessage id="components.downloadReleasesTable.releases" />
</Link>
<Link href={getNodejsChangelog(release.node)}>
</a>
<a href={getNodejsChangelog(release.node)}>
<FormattedMessage id="components.downloadReleasesTable.changelog" />
</Link>
<Link href={getNodeApiLink(release.node)}>
</a>
<a href={getNodeApiLink(release.node)}>
<FormattedMessage id="components.downloadReleasesTable.docs" />
</Link>
</a>
</td>
</tr>
))}
Expand Down
57 changes: 28 additions & 29 deletions components/Downloads/PrimaryDownloadMatrix.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import Link from 'next/link';
import classNames from 'classnames';

import LocalisedLink from '../LocalisedLink';
Expand Down Expand Up @@ -54,7 +53,7 @@ const PrimaryDownloadMatrix = (props: PrimaryDownloadMatrixProps) => {
</ul>
<ul className="no-padding download-platform">
<li>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-x86.msi`}
id="windows-downloadbutton"
data-version={props.node}
Expand All @@ -70,10 +69,10 @@ const PrimaryDownloadMatrix = (props: PrimaryDownloadMatrixProps) => {
</svg>
{downloads.WindowsInstaller}
<p className="small color-lightgray">node-{props.node}-x86.msi</p>
</Link>
</a>
</li>
<li>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}.pkg`}
>
<svg
Expand All @@ -87,10 +86,10 @@ const PrimaryDownloadMatrix = (props: PrimaryDownloadMatrixProps) => {
</svg>
{downloads.MacOSInstaller}
<p className="small color-lightgray">node-{props.node}.pkg</p>
</Link>
</a>
</li>
<li>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}.tar.gz`}
>
<svg
Expand All @@ -104,7 +103,7 @@ const PrimaryDownloadMatrix = (props: PrimaryDownloadMatrixProps) => {
</svg>
{downloads.SourceCode}
<p className="small color-lightgray">node-{props.node}.tar.gz</p>
</Link>
</a>
</li>
</ul>
</div>
Expand All @@ -114,103 +113,103 @@ const PrimaryDownloadMatrix = (props: PrimaryDownloadMatrixProps) => {
<tr>
<th>{downloads.WindowsInstaller} (.msi)</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-x86.msi`}
>
32-bit
</Link>
</a>
</td>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-x64.msi`}
>
64-bit
</Link>
</a>
</td>
</tr>

<tr>
<th>{downloads.WindowsBinary} (.zip)</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-win-x86.zip`}
>
32-bit
</Link>
</a>
</td>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-win-x64.zip`}
>
64-bit
</Link>
</a>
</td>
</tr>

<tr>
<th>{downloads.MacOSInstaller} (.pkg)</th>
<td colSpan={2}>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}.pkg`}
>
64-bit / ARM64
</Link>
</a>
</td>
</tr>
<tr>
<th>{downloads.MacOSBinary} (.tar.gz)</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-darwin-x64.tar.gz`}
>
64-bit
</Link>
</a>
</td>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-darwin-arm64.tar.gz`}
>
ARM64
</Link>
</a>
</td>
</tr>

<tr>
<th>{downloads.LinuxBinaries} (x64)</th>
<td colSpan={2}>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-linux-x64.tar.xz`}
>
64-bit
</Link>
</a>
</td>
</tr>
<tr>
<th>{downloads.LinuxBinaries} (ARM)</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-linux-armv7l.tar.xz`}
>
ARMv7
</Link>
</a>
</td>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-linux-arm64.tar.xz`}
>
ARMv8
</Link>
</a>
</td>
</tr>

<tr>
<th>{downloads.SourceCode}</th>
<td colSpan={2}>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}.tar.gz`}
>
node-{props.node}.tar.gz
</Link>
</a>
</td>
</tr>
</tbody>
Expand Down
18 changes: 8 additions & 10 deletions components/Downloads/SecondaryDownloadMatrix.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import Link from 'next/link';

import DownloadList from './DownloadList';
import { useNextraContext } from '../../hooks/useNextraContext';

Expand All @@ -23,41 +21,41 @@ const SecondaryDownloadMatrix = (props: SecondaryDownloadMatrixProps) => {
<tr>
<th>{additional.DockerImage}</th>
<td>
<Link href="https://hub.docker.com/_/node/">
<a href="https://hub.docker.com/_/node/">
{additional.officialDockerImage}
</Link>
</a>
</td>
</tr>

<tr>
<th>{additional.LinuxPowerSystems}</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-linux-ppc64le.tar.xz`}
>
64-bit
</Link>
</a>
</td>
</tr>

<tr>
<th>{additional.LinuxSystemZ}</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-linux-s390x.tar.xz`}
>
64-bit
</Link>
</a>
</td>
</tr>
<tr>
<th>{additional.AIXPowerSystems}</th>
<td>
<Link
<a
href={`https://nodejs.org/dist/${props.node}/node-${props.node}-aix-ppc64.tar.gz`}
>
64-bit
</Link>
</a>
</td>
</tr>
</tbody>
Expand Down
Loading