chore: Turn on ESLint for markdown #4287
Conversation
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I'm OK with this as it is, but I do think I'd prefer changing the quotes rule to require single quotes as that would probably reduce churn here and also align it with Node.js core practices. (Perhaps it's time to create eslint-plugin-node-core similar to remark-plugin-lint-node.)
nschonni
force-pushed
the
eslint-markdown
branch
from
885c48b to
1ec8034
Compare
| external/ | ||
| build/ | ||
| # Top level await isn't supported till ESLint 8 | ||
| locale/en/blog/release/v17.0.0.md |
There was a problem hiding this comment.
Are we blocked because standard is still using eslint 7.x?
I think I've expressed my opinion in the past, standard does not catch many of real issues and personally I never use it. prettier doesn't catch real issues either.
Just thinking out loud for the future :)
There was a problem hiding this comment.
Yeah, I believe the ESLint upgrade is blocked on prettier, but eslint-plugin-promise just released a compatible version, so that might have been the last one remaining
There was a problem hiding this comment.
All good, as long as someone remembers to revert this later :)
nschonni
force-pushed
the
eslint-markdown
branch
from
e07e48c to
3583c18
Compare
|
I can't review every file, but I suppose these are autofixable mostly, right? From a quick look, the diff looks good, I'll try to have another look tomorrow. |
|
We should look into enabling ESLint caching later. |
3 participants
Turn on linting/fixing for JS blocks in markdown and autofix many formatting issues automatically. Ignored a few more that come up because it parses the document as a whole scope