remove the outdated Deduplication section from event-loop-timers-and-nexttick.md #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplication section appears to be describing how things worked prior to nodejs/node#22842, so is no longer correct. The output in 11.12 is ``` setImmediate 1 process.nextTick a process.nextTick b setImmediate 2 process.nextTick a process.nextTick b ```
ghost
mentioned this pull request
3 tasks
|
This change is still pretty new... can we point out that it acts as normal since 11.2 (or whichever version it was), rather than removing it? |
|
Ideally guides should be versioned like api docs. Since they are not, I was assuming they apply to the latest version, as it does not seem practical to have the same document cover multiple versions. AFAICT the Deduplication section was only recently added (b440166) when it was no longer valid for the latest version. However if you want a more nuanced rewording rather than removal, perhaps the original author (@OmarDarwish) is better suited for that. |
ghost
requested review from
Trott
approved these changes
Apr 2, 2019
added 4 commits
April 4, 2019 11:20
fa: update
it: update
ja: update
zh-CN: update
ghost
approved these changes
Apr 4, 2019
|
@nodejs/nodejs-ko I've just pushed to follow changes of event-loop-timers-and-nexttick.md. Please review this. |
|
@yous LGTM |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplication section appears to be describing how things worked prior to nodejs/node#22842, so is no longer correct. The output in 11.12 is