Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the 'copyright' and 'copyright_year.js' #2151

Merged
1 commit merged into from Mar 14, 2019
Merged

Remove the 'copyright' and 'copyright_year.js' #2151

1 commit merged into from Mar 14, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2019

Due to the discussion at nodejs/TSC#195 (comment), we
shouldn't include an auto copyright_year and its realted token place. So
we should remove it.

@ghost ghost requested a review from fhemberger March 13, 2019 01:35
Trott
Trott previously requested changes Mar 14, 2019
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to include the year. Please don't. It just makes for pointless annual updates that everyone forgets to do.

EDIT 1: I am not a lawyer. Expert opinion welcome, whether it be contrary to mine or not.

EDIT 2: I see this auto-updates the year. That is also problematic, I think, although less so for sure. We should not update the year for material that isn't updated. For minor updates, it should probably be a range of years rather than the latest year. Omitting the year solves the problem.

@Trott
Copy link
Member

Trott commented Mar 14, 2019

Resulting word from the then-Executive Director of the Node.js Foundation on this topic after previous TSC conversation: nodejs/TSC#195 (comment)

Third bullet point: "Adding dates is not preferable. It does not have a legal impact and would be excluded only for ease of administration."

Our current LICENSE file says: "Copyright Node.js contributors. All rights reserved."

@Trott
Copy link
Member

Trott commented Mar 14, 2019

(Although the above was about files we distribute in the source tree and not websites.)

@ghost ghost changed the title Fix:Add the missing copyright as the copy year Remove the 'copyright' and 'copyright_year.js' Mar 14, 2019
Due to the discussion at
nodejs/TSC#195 (comment), we
shouldn't include an auto copyright_year and its realted token place. So
we should remove it.
@ghost
Copy link
Author

ghost commented Mar 14, 2019

@Trott:Thanks, and it's ALWAYS you that is the FIRST to help me a lot!
Now I've removed something useless and make it suitable to the discussion.

@Trott Trott dismissed their stale review March 14, 2019 04:16

Seems OK to me now, although I'll definitely let fhemberger and others have the final say.

@ghost ghost self-requested a review March 14, 2019 06:53
Copy link
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@osk2 osk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aymen94
Copy link
Member

aymen94 commented Mar 14, 2019

LGTM

Copy link
Contributor

@marswong marswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit fdeaa65 into nodejs:master Mar 14, 2019
@ghost ghost deleted the FixCopyYear branch March 14, 2019 23:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants