-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the 'copyright' and 'copyright_year.js' #2151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to include the year. Please don't. It just makes for pointless annual updates that everyone forgets to do.
EDIT 1: I am not a lawyer. Expert opinion welcome, whether it be contrary to mine or not.
EDIT 2: I see this auto-updates the year. That is also problematic, I think, although less so for sure. We should not update the year for material that isn't updated. For minor updates, it should probably be a range of years rather than the latest year. Omitting the year solves the problem.
Resulting word from the then-Executive Director of the Node.js Foundation on this topic after previous TSC conversation: nodejs/TSC#195 (comment) Third bullet point: "Adding dates is not preferable. It does not have a legal impact and would be excluded only for ease of administration." Our current LICENSE file says: "Copyright Node.js contributors. All rights reserved." |
(Although the above was about files we distribute in the source tree and not websites.) |
Due to the discussion at nodejs/TSC#195 (comment), we shouldn't include an auto copyright_year and its realted token place. So we should remove it.
@Trott:Thanks, and it's ALWAYS you that is the FIRST to help me a lot! |
Seems OK to me now, although I'll definitely let fhemberger and others have the final say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Due to the discussion at nodejs/TSC#195 (comment), we
shouldn't include an auto copyright_year and its realted token place. So
we should remove it.