Skip to content

Changed command for building node modules to npm ci #2080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhemberger merged 3 commits into from
Feb 15, 2019
Merged

Changed command for building node modules to npm ci #2080

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b744d7f
Changed command for building node modules to npm ci
ddc22 Feb 15, 2019
afaa6c7
Added explanation for npm ci and fixed other instances
ddc22 Feb 15, 2019
77d474b
Update locale/en/docs/guides/nodejs-docker-webapp.md
ZYSzys Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions locale/en/docs/guides/nodejs-docker-webapp.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,15 @@ COPY package*.json ./

RUN npm install
# If you are building your code for production
# RUN npm install --only=production
# RUN npm ci --only=production
```

Note that, rather than copying the entire working directory, we are only copying
the `package.json` file. This allows us to take advantage of cached Docker
layers. bitJudo has a good explanation of this
[here](http://bitjudo.com/blog/2014/03/13/building-efficient-dockerfiles-node-dot-js/).
[here](http://bitjudo.com/blog/2014/03/13/building-efficient-dockerfiles-node-dot-js/).
Furthermore, the `npm ci` command, specified in the comments, helps provide faster, reliable, reproducible builds for production environments.
You can read more about this [here](https://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable).

To bundle your app's source code inside the Docker image, use the `COPY`
instruction:
Expand Down Expand Up @@ -156,7 +158,7 @@ COPY package*.json ./

RUN npm install
# If you are building your code for production
# RUN npm install --only=production
# RUN npm ci --only=production

# Bundle app source
COPY . .
Expand Down