Update simple-profiling.md #1975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified a missing parameter in the performance update (I was using v11.2.0). Also updated code sample that is runnable from copy/paste, and added link to installing Express.
Contributor
|
Thank you! Some style and consistency notes:
|
Contributor
|
cc @nodejs/documentation @nodejs/performance @nodejs/diagnostics @nodejs/v8 (sorry if some mentions are wrong). |
ofrobots
reviewed
Jan 3, 2019
mmarchini
approved these changes
Jan 3, 2019
Contributor
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
LGTM with style-nits addressed.
Updated based on styling guidelines.
vsemozhetbyt
reviewed
Jan 3, 2019
vsemozhetbyt
reviewed
Jan 3, 2019
vsemozhetbyt
reviewed
Jan 3, 2019
Accepted suggested change in line length Co-Authored-By: kcacciatore <[email protected]>
indentation fix Co-Authored-By: kcacciatore <[email protected]>
Flarna
reviewed
Jan 3, 2019
Removed explicit versioning of Express
Realized the port number in the code sample was inconsistent with the curl/ab instructions
mcollina
reviewed
Jan 4, 2019
This was referenced Jun 29, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified a missing parameter in the performance update (I was using v11.2.0). Also updated code sample that is runnable from copy/paste, and added link to installing Express.