zh-TW：Add missing translation for 'Collab Summit' #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this missing Traditional Chinese for 'Collab Summit'.
ghost
requested review from
osk2
reviewed
Sep 29, 2018
Contributor
osk2
left a comment
osk2
left a comment
There was a problem hiding this comment.
I'm thinking that if it's necessary to translate "Collab Summit". if so, then we'll need to translate words in collab-summit.md too.
Author
|
You see that we've translated once about "Collab Submmit" as "協作者峰會". And for the rest, there's no need to translate because they are fixed special pharses. |
Contributor
|
I mean the word "Collab Summit" :P I left them untranslated in |
osk2
approved these changes
Sep 29, 2018
Contributor
osk2
left a comment
osk2
left a comment
There was a problem hiding this comment.
Nice, looks much better now 👍
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add this missing Traditional Chinese for 'Collab Summit'.