Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Sep 14, 2018

This eliminates a warning from npm audit. It's a semver major update,
so we should look at output carefully, but all tests pass, so that's
something...

This eliminates a warning from `npm audit`. It's a semver major update,
so we should look at output carefully, but all tests pass, so that's
something...
@fhemberger
Copy link
Contributor

Diffed the generated files before and after the update:

  • Escaping of a few characters has changed (' -> ', "-> ", & -> & in URLs)
  • Now HTML is properly escaped in <pre> code blocks
  • No <p> around <ul>

Breaking changes (fixed manually):

  • Markdown inside HTML is no longer supported:

    • locale/en/about/resources.md
    • locale/en/blog/npm/2013-outage-postmortem.md
    • locale/ko/about/resources.md
    • locale/uk/about/resources.md
    • locale/zh-cn/about/resources.md
    • locale/zh-cn/docs/guides/debugging-getting-started.md
  • Some slight misrendering (manually fixed, editor mistakes):

    • locale/en/blog/npm/managing-node-js-dependencies-with-shrinkwrap.md
    • locale/en/docs/guides/simple-profiling.md
    • locale/uk/docs/guides/simple-profiling.md
    • locale/zh-cn/docs/guides/simple-profiling.md
  • Could somebody from the @nodejs/nodejs-cn team please check the following files (some underscores were changed to <em>):

    • locale/zh-cn/docs/guides/backpressuring-in-streams.md
    • locale/zh-cn/docs/guides/buffer-constructor-deprecation.md
    • locale/zh-cn/docs/guides/timers-in-node.md

fhemberger added a commit that referenced this pull request Sep 16, 2018
@fhemberger
Copy link
Contributor

Closing, please see #1811 for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants