-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Better structure for guides' overview page #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,30 @@ | ||
| --- | ||
| title: Guides | ||
| layout: guides-index.hbs | ||
| layout: docs.hbs | ||
| --- | ||
|
|
||
| # Guides | ||
|
|
||
| ## General | ||
|
|
||
| - [Getting Started Guide](getting-started-guide/) | ||
| - [Debugging - Getting Started](debugging-getting-started/) | ||
| - [Easy profiling for Node.js Applications](simple-profiling/) | ||
| - [Dockerizing a Node.js web app](nodejs-docker-webapp/) | ||
|
|
||
|
|
||
| ## Node.js core concepts | ||
|
|
||
| - [Overview of Blocking vs Non-Blocking](blocking-vs-non-blocking/) | ||
| - [The Node.js Event Loop, Timers, and process.nextTick()](event-loop-timers-and-nexttick/) | ||
| - [Don't Block the Event Loop (or the Worker Pool)](dont-block-the-event-loop/) | ||
| - [Timers in Node.js](timers-in-node/) | ||
|
|
||
|
|
||
| ## Module related guides | ||
|
|
||
| - [Anatomy of an HTTP Transaction](anatomy-of-an-http-transaction/) | ||
| - [Working with Different Filesystems](working-with-different-filesystems/) | ||
| - [Backpressuring in Streams](backpressuring-in-streams/) | ||
| - [Domain Module Postmortem](domain-postmortem/) | ||
| - [How to publish N-API package](publishing-napi-modules/) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,26 @@ | ||
| --- | ||
| title: 가이드 | ||
| layout: guides-index.hbs | ||
| layout: docs.hbs | ||
| --- | ||
|
|
||
| # 가이드 | ||
|
|
||
| ## General | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably best to leave this change up to the localization teams so they can pick language-appropriate titles.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd like this change to land and let the Korean language team create a follow-up PR for the new headlines. /cc @nodejs/nodejs-ko |
||
|
|
||
| - [디버깅 - 시작하기](debugging-getting-started/) | ||
| - [Node.js 애플리케이션의 간단한 프로파일링](simple-profiling/) | ||
| - [Node.js 웹 앱의 도커라이징](nodejs-docker-webapp/) | ||
|
|
||
|
|
||
| ## Node.js core concepts | ||
|
|
||
| - [블록킹과 논블록킹 살펴보기](blocking-vs-non-blocking/) | ||
| - [Node.js 이벤트 루프, 타이머, `process.nextTick()`](event-loop-timers-and-nexttick/) | ||
| - [Node.js의 Timers](timers-in-node/) | ||
|
|
||
|
|
||
| ## Module related guides | ||
|
|
||
| - [HTTP 트랜잭션 해부](anatomy-of-an-http-transaction/) | ||
| - [여러 파일 시스템에서 작업하기](working-with-different-filesystems/) | ||
| - [도메인 모듈 포스트모템](domain-postmortem/) | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| --- | ||
| title: Керівництва | ||
| layout: guides-index.hbs | ||
| layout: docs.hbs | ||
| --- | ||
|
|
||
| # Guides | ||
|
|
||
| - [Easy profiling for Node.js Applications](simple-profiling/) | ||
| - [Dockerizing a Node.js web app](nodejs-docker-webapp/) | ||
| - [Anatomy of an HTTP Transaction](anatomy-of-an-http-transaction/) | ||
| - [Working with Different Filesystems](working-with-different-filesystems/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would impact reference doc pages too. We probably shouldn't use this layout for guides and leave this line the way it was.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What reference doc pages are you referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry. I misread. It'd probably be good to be able to keep the continuation feature though. Perhaps we should consider putting the guides in sub-folders and number-prefix them to keep some sort of order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that as well but decided against it (for now):
This section will be changed anyway in the relaunch we're currently working on, so it's a temporary fix anyway.