blog: diag wg update and --debug deprecation #1156
Conversation
|
|
||
| As a result, **running `node --debug`** (or its variants like `--debug-brk` and | ||
| `--debug-port=1234`) **will present a deprecation warning now and stop working | ||
| in a future release**. To debug your code from now on, use `node --inspect` or |
There was a problem hiding this comment.
Should we mention that we understand that introducing a deprecation in 7.x breaks backwards compatibility and would not normally be permitted, but we need to do it to keep in sync with v8?
There was a problem hiding this comment.
Good idea, updated, PTAL. Thanks!
|
|
||
| As a result, **running `node --debug`** (or its variants like `--debug-brk` and | ||
| `--debug-port=1234`) **will present a deprecation warning now and stop working | ||
| in a future release**. To debug your code from now on, use `node --inspect` or |
There was a problem hiding this comment.
If the warning is going to be added only in v7 I think we should be specific on that
|
@italoacasas I fixed up to not discuss future plans for the moment. In addition to the deprecation warning, nodejs/node#11441 proposes aliasing to inspect equivalents starting in 8.x. |
|
@joshgav this looks LGTM to me, @sam-github ?? btw, I don't have access to this repo, can someone from @nodejs/website land this if Sam is ok with the change, please. This feature is going to be released on Feb 28(next Tuesday) and is going to be nice if we can have this on the blog ASAP. Update 1: @jasnell something to add here? |
|
@italoacasas yes this repo has a LOT of collaborators. It should be a problem to get this merged in time once it is ready to land. |
| [node-report]: https://github.com/nodejs/node-report | ||
| [llnode]: https://github.com/nodejs/llnode | ||
|
|
||
| Over the coming months we hope to graduate these from experimental status with |
There was a problem hiding this comment.
"experimental" might be confused with the "Stability Index - Experimental". Some of these tools like async_hooks will likely graduate to "Stability Index - Experimental" from a pre-experimental state.
There was a problem hiding this comment.
Thanks for that link Andreas. Updated language to be a bit more generic, PTAL.
|
A couple minor fixes as per below. Squashed and rebased. Will land tomorrow (Tues 2/28) morning if no objections. Thanks!
|
PR-URL: #1156 Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in a6fa352 and https://nodejs.org/en/blog/wg/diag-wg-update-2017-02/ Thanks for the reviews! |
A post to go with
--debugdeprecation, planned to land in 7.7.0 on Feb 28 (nodejs/node#11275).Starts with a review of progress on diagnostic tools in the past year, then discusses transition from legacy V8 Debugger to Inspector.
I think this can land anytime before 7.7.0.
/cc @italoacasas @nodejs/diagnostics