-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language picker #806
Comments
Sure, I guess? But we kinda need it before then. Can't hold everything up for that. |
one thing we could do if we're really getting translation efforts back up again is probe for the activeness of the i18n WGs |
Quoting myself here from nodejs/iojs.org#235:
EDIT New link: https://www.nginx.com/resources/wiki/modules/accept_language/ I think it's the most reliable way to determine a user's language without the need for user interaction. |
we should also probably assemble a separate team to control translation efforts. the iojs way wasn't the best |
@Fishrock123 Ahh, no problem! Didn't know that. |
@fhemberger i wouldn't do it automatically though. maybe a hint from somewhere within the site asking if you want to switch to the version of the site in your language |
@ore https://github.com/nodejs/nodejs-ko is quite active.
My point also, but we shouldn't have the selection be flags, only the initial, along with the Language indicator. I.e. [🇩🇪 DE] is a little more visible than [DE] for such a thing.
perhaps but idk if I'm comfortable not having an easy way to adjust it? I'm willing to look into the nginx thing though |
@Fishrock123 yeah, but that's one of the only ones 😞 |
@ore You still could add a cookie for example: "Nah, I want to browse the site in Klingon". In case we're adding a manual selection dropdown, this should be done anyway. |
Link to the nginx module is now https://www.nginx.com/resources/wiki/modules/accept_language/ |
I'd recommend (1) content negotiation and then (2) a simple popup with a textual list of languages. I would NOT recommend flags. You could put a little stylized globe for an icon to represent the language choice perhaps. English 🇦🇺 is spoken in a lot of places, as is French🇧🇱, etc. for that matter. Would be a lot of flags. You could add a cookie and not change the URL. That means if you're browsing in French and you send the link to someone who prefers Spanish, they will see the same content in Spanish. It might be better to redirect to a specific URL ( like /fr/ or /en/ ) so that links go to the right thing, with a popup offering to take you to your "preferred" language (content / cookie negotiated) if different. |
i am going to open a separate issue regarding translation in general in this repo |
From The Korean Translation Group: nodejs/nodejs-ko#381 (comment):
|
Hello, I'm not sure what is the current status with language picker implementation. Can I propose something? I'm ready to implement and create PR with language picker on my own. Does it's have a reason? |
@alexandrtovmach just an example on my above discussion, instead of flags use |
@srl295 could you take a look on my PR? |
Implemented simple language picker #806, to make better UX on the website How it looks you can check here: https://www.loom.com/share/9022dba48c1d42a486df212e4acabbdf
This feature already merged, so I think is good idea to close this issue |
Now that #490 has landed and the related build/deployment work seems to be completed, we should be able to get the language groups once again more involved with the website.
We should also start thinking of a way to choose the language.
I'm not sure io.js's way was really that great. I know we discussed the flag thing before, but to me that is the most easily recognizable way.
We don't have to have that open a country list, but we can use it as a prompt for language nonetheless.
cc @nodejs/website
cc also @leo who may have some ideas?
The text was updated successfully, but these errors were encountered: