Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design issue for nodejs.org/download #1232

Closed
iliakan opened this issue May 20, 2017 · 6 comments
Closed

Design issue for nodejs.org/download #1232

iliakan opened this issue May 20, 2017 · 6 comments

Comments

@iliakan
Copy link

iliakan commented May 20, 2017

Hi,

A friend of mine asked me how to get Node 7, because https://nodejs.org/en/download/ only has 6.
I couldn't find it on that page, so I went google and found https://nodejs.org/en/download/current/.

Then I discovered that both me and him (20+ years of programming xp) couldn't figure out that "Current" is a clickable button on that page.

Guess that's not only us who find these buttons "under-designed".

@gibfahn
Copy link
Member

gibfahn commented May 20, 2017

Guess that's not only us who find these buttons "under-designed".

I'm sure you're not the only one (and it seems a reasonable request), although AFAIK you're the first person to raise it.

What do you think should change to make it more obvious that it's a button? Maybe it should have some shadow below to make stand out? That seems to be what Google suggest in their material design guidelines, and we seem to be going for quite a flat design, so maybe that would help?

@refack
Copy link
Contributor

refack commented May 20, 2017

I would:

  1. set the .download-version-toggle { background-color: white; }
  2. increase the button's border radius and remove margin
.download-version-toggle a {
    /* margin: 2px; */
    padding: 5px 2px;
    border-radius: 5px;
}
.download-version-toggle a:first-child { margin-bottom: 4px; }
  1. optional remove the dark green border from .download-version-toggle

image

@refack
Copy link
Contributor

refack commented May 20, 2017

PR: #1233

@lpinca
Copy link
Member

lpinca commented May 21, 2017

Refs: #947

@iliakan
Copy link
Author

iliakan commented May 22, 2017

Looking at the screenshot above, it's still not quite obvious that it's a button. Especially when in the context of the whole table.

Maybe make it another kind of selector, like a "switch" or something.

@refack
Copy link
Contributor

refack commented May 22, 2017

@iliakan PTAL at #1233

refack added a commit to refack/nodejs.org that referenced this issue Jun 16, 2017
fhemberger pushed a commit that referenced this issue Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants