Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules shows NODE_EMBEDDER_MODULE_VERSION #20

Closed
richardlau opened this issue Oct 2, 2023 · 1 comment · Fixed by #23
Closed

modules shows NODE_EMBEDDER_MODULE_VERSION #20

richardlau opened this issue Oct 2, 2023 · 1 comment · Fixed by #23

Comments

@richardlau
Copy link
Member

richardlau commented Oct 2, 2023 •
edited
Loading

e.g. https://nodejs.org/download/release/index.json

    {
        "version": "v20.8.0",
        "date": "2023-09-28",
        "files": [
            "aix-ppc64",
            "headers",
            "linux-arm64",
            "linux-armv7l",
            "linux-ppc64le",
            "linux-s390x",
            "linux-x64",
            "osx-arm64-tar",
            "osx-x64-pkg",
            "osx-x64-tar",
            "src",
            "win-arm64-7z",
            "win-arm64-zip",
            "win-x64-7z",
            "win-x64-exe",
            "win-x64-msi",
            "win-x64-zip",
            "win-x86-7z",
            "win-x86-exe",
            "win-x86-msi",
            "win-x86-zip"
        ],
        "npm": "10.1.0",
        "v8": "11.3.244.8",
        "uv": "1.46.0",
        "zlib": "1.2.13.1-motley",
        "openssl": "3.0.10+quic",
        "modules": "NODE_EMBEDDER_MODULE_VERSION",
        "lts": false,
        "security": false
    },

We'll need to adjust

nodejs-dist-indexer/dist-indexer.js

Line 328 in d10a601

let m = rawData.match(/^#define NODE_MODULE_VERSION\s+([^\s]+)\s+.+$/m)
for the changes made by nodejs/node#49279.
richardlau added a commit to richardlau/nodejs-dist-indexer that referenced this issue Oct 13, 2023
@richardlau
exclude NODE_EMBEDDER_MODULE_VERSION string
74f064f 
When extracting the module version from `src/node_version.h`, ignore
the line:
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION

This will pick up the default value from the header as the official
Node.js builds do not define `NODE_EMBEDDER_MODULE_VERSION`.

Fixes: nodejs#20
Refs: nodejs/node#49279
@richardlau richardlau mentioned this issue Oct 13, 2023
Merged
richardlau added a commit that referenced this issue Oct 16, 2023
@richardlau
exclude NODE_EMBEDDER_MODULE_VERSION string (#23)
3c31920 
When extracting the module version from `src/node_version.h`, ignore
the line:
#define NODE_MODULE_VERSION NODE_EMBEDDER_MODULE_VERSION

This will pick up the default value from the header as the official
Node.js builds do not define `NODE_EMBEDDER_MODULE_VERSION`.

Fixes: #20
Refs: nodejs/node#49279
@richardlau
Copy link
Member Author

This is now fixed after deploying [email protected] to the server, removing all the entries with NODE_EMBEDDER_MODULE_VERSION from the cached versions file (.dist-indexer-version-cache) and then rerunning the indexer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exclude NODE_EMBEDDER_MODULE_VERSION string richardlau/nodejs-dist-indexer
1 participant
@richardlau