test: fix buffer alloc tests #9998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
code-and-learn
cjihrig
requested changes
Dec 3, 2016
| @@ -1027,7 +1027,8 @@ assert(Buffer.allocUnsafe(1).parent instanceof ArrayBuffer); | |||
| Buffer.poolSize = ps; | |||
|
|
|||
| // Test Buffer.copy() segfault | |||
| assert.throws(() => Buffer.allocUnsafe(10).copy()); | |||
| assert.throws(() => Buffer.allocUnsafe(10).copy(), | |||
| /TypeError: argument should be a Buffer/); | |||
There was a problem hiding this comment.
Can you line this up with the beginning of the arrow function on the previous line. Also, if you're validating the entire error message, you can add ^ and $ to the regular expression.
There was a problem hiding this comment.
Lined up with arrow function. I did not match for start of string and end of string since error message that I saw were lengthy and contained much more to the string thats in validation.
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument
levsoroka
force-pushed
the
test-buffer-alloc
branch
from
68d9696
to
2426521
Compare
cjihrig
approved these changes
Dec 4, 2016
jasnell
approved these changes
Dec 5, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 5, 2016
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument PR-URL: #9998 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in ee97f84. thank you for the PR and for participating in the code-and-learn! |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument PR-URL: #9998 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument PR-URL: nodejs#9998 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument PR-URL: nodejs#9998 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Replaced assert.equal to assert.strictEqual. Fixed assert.throws syntax and added second argument PR-URL: #9998 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Replaced assert.equal to assert.strictEqual.
Fixed assert.throws syntax and added second argument to assert.throws