Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: strictEqual in test-cli-eval-event test #9964

Closed
wants to merge 1 commit into from
Closed

test: strictEqual in test-cli-eval-event test #9964

wants to merge 1 commit into from

Conversation

flekmatik
Copy link

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

Description of change

Using strictEqual instead of equal in test/parallel/test-cli-eval-event.js

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added lib / src Issues and PRs related to general changes in the lib or src directory. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Dec 5, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5186/

@cjihrig
Copy link
Contributor

cjihrig commented Dec 5, 2016

Landed in 38ed3fb. Thanks!

@cjihrig cjihrig closed this Dec 5, 2016
cjihrig pushed a commit that referenced this pull request Dec 5, 2016
@cjihrig
test: use strictEqual in test-cli-eval-event.js
38ed3fb 
PR-URL: #9964
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@addaleax
test: use strictEqual in test-cli-eval-event.js
a771f21 
PR-URL: #9964
Reviewed-By: Colin Ihrig <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@addaleax
test: use strictEqual in test-cli-eval-event.js
7277c37 
PR-URL: nodejs#9964
Reviewed-By: Colin Ihrig <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: use strictEqual in test-cli-eval-event.js
d014744 
PR-URL: nodejs#9964
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: use strictEqual in test-cli-eval-event.js
457af87 
PR-URL: #9964
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: use strictEqual in test-cli-eval-event.js
5304202 
PR-URL: #9964
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: use strictEqual in test-cli-eval-event.js
7a964c3 
PR-URL: #9964
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
@aliscco aliscco mentioned this pull request Jun 21, 2023
Open
This was referenced Jul 1, 2023
Open
Open
This was referenced Jul 8, 2023
Open
Open
@leonardoadame leonardoadame mentioned this pull request Sep 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. lib / src Issues and PRs related to general changes in the lib or src directory. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@flekmatik @cjihrig @mscdex @MylesBorins @addaleax @imyller @nodejs-github-bot