test: improve test-cluster-net-listen.js #9953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
cluster
imyller
added
the
code-and-learn
| var net = require('net'); | ||
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| let cluster = require('cluster'); |
There was a problem hiding this comment.
why not const for cluster and net?
There was a problem hiding this comment.
Definitely, please use const for all require statemnts
convert var to const
|
I rebased, made the |
Trott
approved these changes
Dec 23, 2016
jasnell
approved these changes
Dec 23, 2016
gibfahn
approved these changes
Dec 23, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 24, 2016
convert var to const PR-URL: nodejs#9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
|
Landed in 2bba2d2. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
convert var to const PR-URL: #9953 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
This was referenced Jul 1, 2023
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Test
Description of change
convert var to const/let
convert assert.equal to assert.strictEqual