Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test for crypto padding #9906

Closed

Conversation

julianduque
Copy link
Contributor

@julianduque julianduque commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, crypto

Description of change

Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@julianduque julianduque added the crypto Issues and PRs related to the crypto subsystem. label Dec 1, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws
@julianduque
Copy link
Contributor Author

@cjihrig needed to rebase and force push a change, my previous commit had a minor lint error

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

@Trott
Copy link
Member

Trott commented Dec 4, 2016

@Trott
Copy link
Member

Trott commented Dec 4, 2016

Single failure on CI is unrelated.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: nodejs#9906
Reviewed-By: Colin Ihrig <[email protected]>
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Landed in 72b1f79. Thanks!!!

@Trott Trott closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: #9906
Reviewed-By: Colin Ihrig <[email protected]>
@julianduque julianduque deleted the test-crypto-padding-refactor branch December 5, 2016 03:22
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: nodejs#9906
Reviewed-By: Colin Ihrig <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: nodejs#9906
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: #9906
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: #9906
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
Replace assert.equal with assert.strictEqual and use RegExp in
assert.throws

PR-URL: #9906
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants