Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace equal with strictEqual in crypto #9886

Closed
wants to merge 1 commit into from
Closed

test: replace equal with strictEqual in crypto #9886

wants to merge 1 commit into from

Conversation

julianduque
Copy link
Contributor

@julianduque julianduque commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Replace assert.equal with assert.strictEqual in crypto cipher-decipher test

@julianduque
test: replace equal with strictEqual in crypto
c2bf525 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5063/

evanlucas
evanlucas approved these changes Dec 2, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

jasnell pushed a commit that referenced this pull request Dec 4, 2016
@julianduque @jasnell
test: replace equal with strictEqual in crypto
a8c2bec 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: #9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 4, 2016

Landed in a8c2bec. thank you!

@jasnell jasnell closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@julianduque @addaleax
test: replace equal with strictEqual in crypto
57f060c 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: #9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@julianduque @addaleax
test: replace equal with strictEqual in crypto
5446b3c 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: nodejs#9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@julianduque
test: replace equal with strictEqual in crypto
281c796 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: nodejs#9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@julianduque @MylesBorins
test: replace equal with strictEqual in crypto
552169e 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: #9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@julianduque @MylesBorins
test: replace equal with strictEqual in crypto
bfc07e5 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: #9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@julianduque @MylesBorins
test: replace equal with strictEqual in crypto
8e0a434 
Replace assert.equal with assert.strictEqual in
crypto cipher-decipher test

PR-URL: #9886
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@evanlucas evanlucas evanlucas approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.