Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: refactor _debugger.js #9860

Closed
wants to merge 1 commit into from
Closed

debugger: refactor _debugger.js #9860

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 30, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

debugger

Description of change
  • == -> ===
  • use white space in array to improve readability

@Trott
debugger: refactor _debugger.js
caf1ca8 
* `==` -> `===`
* use white space in array to improve readability
@Trott Trott added addons Issues and PRs related to native addons. debugger and removed addons Issues and PRs related to native addons. labels Nov 30, 2016
cjihrig
cjihrig approved these changes Nov 30, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformatting of ignored seems like noise to me, but everything else LGTM.

@lpinca
Copy link
Member

lpinca commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5039/

Trott added a commit to Trott/io.js that referenced this pull request Dec 5, 2016
@Trott
debugger: refactor _debugger.js
34a6c85 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: nodejs#9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Dec 5, 2016

Landed in 34a6c85

@Trott Trott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@Trott @Fishrock123
debugger: refactor _debugger.js
ac8d212 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: #9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@Trott
debugger: refactor _debugger.js
1acebfe 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: nodejs#9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@Trott @MylesBorins
debugger: refactor _debugger.js
724910a 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: #9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@Trott @MylesBorins
debugger: refactor _debugger.js
106e6cd 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: #9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
debugger: refactor _debugger.js
8abfeb4 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: #9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
debugger: refactor _debugger.js
f5603a6 
* `==` -> `===`
* use white space in array to improve readability

PR-URL: #9860
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 21, 2016
Merged
Merged
@Trott Trott deleted the refactor-debugger branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @lpinca @targos @cjihrig @MylesBorins