Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: convert offset & length to int properly #9815

Closed
wants to merge 3 commits into from
Closed

buffer: convert offset & length to int properly #9815

wants to merge 3 commits into from

Commits on Nov 27, 2016

  1. buffer: convert offset & length to int properly 

    As per ecma-262 2015's #sec-%typedarray%-buffer-byteoffset-length,
`offset` would be an integer, not a 32 bit unsigned integer. Also,
`length` would be an integer with the maximum value of 2^53 - 1, not a
32 bit unsigned integer.

This would be a problem because, if we create a buffer from an
arraybuffer, from an offset which is greater than 2^32, it would be
actually pointing to a different location in arraybuffer. For example,
if we use 2^40 as offset, then the actual value used will be 0,
because `byteOffset >>>= 0` will convert `byteOffset` to a 32 bit
unsigned int, which is based on 2^32 modulo.

This is a redo, as the ca37fa5 broke
CI.

Refer: nodejs#9814
Refer: nodejs#9492
    @thefourtheye
    thefourtheye committed Nov 27, 2016
    Configuration menu
    Copy the full SHA
    884eb35 View commit details
    Browse the repository at this point in the history

  2. avoid failing in race condition

    @thefourtheye
    thefourtheye committed Nov 27, 2016
    Configuration menu
    Copy the full SHA
    9aa3ab5 View commit details
    Browse the repository at this point in the history

  3. include all expected error messages

    @thefourtheye
    thefourtheye committed Nov 27, 2016
    Configuration menu
    Copy the full SHA
    7d4f1c7 View commit details
    Browse the repository at this point in the history