Improvements to tls API documentation, batch 1 #9800

sam-github · 2016-11-25T20:38:23Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

doc,tls

Description of change

Improvements to tls API documentation.

sam-github · 2016-11-25T20:40:04Z

@nodejs/crypto @nodejs/documentation @silverwind @jasnell

sam-github · 2016-11-25T20:46:56Z

doc/api/tls.md

 <!-- YAML
 added: v0.3.2
 -->

 * `options` {Object}
-  * `pfx` {string|Buffer} A string or `Buffer` containing the private key,
-    certificate and CA certs of the server in PFX or PKCS12 format. (Mutually
-    exclusive with the `key`, `cert`, and `ca` options.)


My tests and reading of code show it not mutually exclusive with key/cert, btw, and it would be quite strange if it was mutually exclusive with ca. I am still extending test suite to confirm this.

silverwind

Few notes regarding docs.

silverwind · 2016-11-25T20:45:15Z

doc/api/tls.md

+[`tls.TLSSocket`]s.
+
+Consult
+<https://www.openssl.org/docs/man1.0.2/apps/ciphers.html#CIPHER-LIST-FORMAT> for


Maybe use a square bracket link here and move the actual link to the bottom?

ok, maybe In a follow on commit, because this style of link to openssl docs is pervasive here and in crypto.md, I can change them all in one go.

silverwind · 2016-11-25T20:47:14Z

doc/api/tls.md

  cb();
 });
 server.on('resumeSession', (id, cb) => {
-  cb(null, tlsSessionStore[id.toString('hex')] || null);
+  cb(null, tlsSessionStore[id.tostring('hex')] || null);


yes. I was staring and staring at this, but I didn't see the case change. Now I do.

silverwind · 2016-11-25T20:58:55Z

doc/api/tls.md

+  * `ca`{string|string[]|Buffer|Buffer[]} Optional CA certificates to trust.
+    Default is the well-known CAs from Mozilla. When connecting to peers that
+    use certificates issued privately, or self-signed, the private root CA or
+    self-signed certificate must be provided to verify the peer.


Maybe add a word that it will replace default CAs?

Isn't that how all default values work? The default is used when you don't specify the option. If you specify the option, the default isn't used.

I can spell it out if necessary, but the other Optional x. Default is y.
I think the old text used to be confusing, which is why some people thought it could possibly be additive.

sorry, meant to write: but the other Optional x. Default is y. don't spell out that x replaces y if you specify it.

Right, you have a point. It's probably okay your way.

I do feel there is a missing section describing the basic authentication model of TLS, which will make all the buttons and dials more clear. Also, the examples are terrible, but I ran out of time. Maybe on the plane next week I'll rewrite them.

silverwind · 2016-11-25T21:02:30Z

doc/api/tls.md

+  * `honorCipherOrder` {boolean} Attempt to use the server's cipher suite
+    preferences instead of the client's. When `true`, causes
+    `SSL_OP_CIPHER_SERVER_PREFERENCE` to be set in `secureOptions`, see
+    [OpenSSL Options][] for more information.


Defaults to true.

Did you read the Note below? It doesn't default to true if you do new tls.TLSSocket({isServer: true, ...}).

cf.

node/lib/_tls_wrap.js

Line 917 in 1f45d7a

this.honorCipherOrder = true;

Not sure I follow. What influence does isServer have over honorCipherOrder? The linked code seems pretty clear that it is true unless user-provided.

See my comment two above. The linked code is in tls.createServer(), that code isn't run when calling new tls.TLSSocket() (server or client variant), and of course not when calling tls.connect(), not that it would matter in that case, its a server only option.

Clearly you are finding this confusing, though, and the docs shouldn't be confusing. Any suggestions for making it clear that its true by default when using tls.createServer(), but not when using new tls.TLSSocket({isServer: true, ...})? In other words, the common way of making server sockets had a default value, but the other supported and documented way of making them does not set it?

I thought I said that pretty explicitly.

Thanks, I see it now. I'd argue that it should be the default for all servers, at least that was the intention when I made that change. Should be a pretty low-impact change, no?

I agree its odd. In the process of documenting the existing behaviour, I found many odd and irregular aspects of the TLS API, but this PR documents TLS "as is". I definitely encourage you to PR a fix to move the setting of the default out of function Server() and into _tls_common where it can apply to all TLS sockets, and be based on the .isServer property. If you don't, I will. I consider completing the docs to be step 1 to cleaning up the API. In the absence of docs, its hard for reviewers to understand why behaviour is inconsistent and needs to be fixed.

I have started a PR to make it default for all servers, FYI, @silverwind, but might not PR it until I'm back from node interactive. Btw, look for me if you are down here.

👍 to that, I'm not too familiar around tls, so I welcome you doing that change. It was certainly an oversight when we flipped that option.

Oh, and I'm unfortunately not attending NI.

silverwind · 2016-11-25T21:04:13Z

doc/api/tls.md

+    [Perfect Forward Secrecy][]. Use `openssl dhparam` to create the parameters.
+    The key length must be greater than or equal to 1024 bits, otherwise an
+    error will be thrown. It is strongly recommended to use 2048 bits or larger
+    for stronger security. If omitted or invalid, the parameters are silently


adequate security?

Verbatim copy of existing text: https://github.com/nodejs/node/blob/1f45d7aa41291383ce63cca5f80fd2a2a73d7603/doc/api/tls.md#tlscreateserveroptions-secureconnectionlistener

sam-github · 2016-11-25T22:12:10Z

Thanks, I'll fix the stuff you found.

mscdex · 2016-11-26T03:58:39Z

The number of commits seems a bit much, can't some of the common changes (e.g. 'describe' commits) be squashed together?

sam-github · 2016-11-26T05:01:59Z

@mscdex of course I can squash before merge, each commit would become a bullet point. squashing is easy, unsquashing is hard, which is why its like this for now. @jasnell suggested a series of small commits would make it easier to review than a mega-rewrite.

Trott · 2016-11-26T05:39:00Z

doc/api/crypto.md

@@ -1653,8 +1653,8 @@ the `crypto`, `tls`, and `https` modules and are generally specific to OpenSSL.
  </tr>
  <tr>
    <td><code>SSL_OP_CIPHER_SERVER_PREFERENCE</code></td>
-    <td>Uses the server's preferences instead of the clients when selecting a
-    cipher. See
+    <td>Attempt to use the server's preferences instead of the client's when


To use consistent verb conjugation with (most of) the other entries in this table, it would seem this should be Attempts rather than Attempt. (There's also an Allow below that should be Allows.)

sam-github · 2016-11-30T21:56:27Z

doc/api/tls.md

+  * `secureOptions` {number} Optionally affect the OpenSSL protocol behaviour,
+    which is not usually necessary. This should be used carefully if at all!
+    Value is a numeric bitmask of the `SSL_OP_*` options from
+    [OpenSSL Options][].


This may replace #9340

sam-github · 2016-12-08T21:54:05Z

@nodejs/security, one of you care to review for accuracy?

@Trott I addressed your feedback, do you have time to review again?

@jasnell or @Trott, opinion on merging as series of commits, or @mscdex 's suggestion of squashing them, perhaps into one per test:/doc:/tls: subsystem?

mscdex · 2016-12-08T21:57:38Z

@sam-github For review it's fine as-is, but I just wanted to make sure if/when this PR is landed, that the like-commits get squashed together and not landed as-is.

Trott · 2016-12-08T22:42:02Z

test/parallel/test-tls-passphrase.js

 var cert = fs.readFileSync(path.join(common.fixturesDir, 'pass-cert.pem'));

+assert(Buffer.isBuffer(passKey));
+assert(Buffer.isBuffer(cert));
+assert.equal(typeof passKey.toString(), 'string');


Nit: assert.strictEqual() instead of assert.equal() here and anywhere else it shows up

I did it, though I don't understand why. The only difference is that now the test will fail if typeof doesn't return a string, or if a string literal is not a string, both of which would be crash the world bugs in V8.

Trott · 2016-12-08T22:42:03Z

test/parallel/test-tls-passphrase.js

 var cert = fs.readFileSync(path.join(common.fixturesDir, 'pass-cert.pem'));

+assert(Buffer.isBuffer(passKey));
+assert(Buffer.isBuffer(cert));
+assert.equal(typeof passKey.toString(), 'string');


Nit: assert.strictEqual() instead of assert.equal() here and anywhere else it shows up

Trott · 2016-12-08T22:44:33Z

test/parallel/test-tls-passphrase.js

+    rejectUnauthorized: false
+  }, common.mustCall(function() {}));
+  */
+})).unref();

 assert.throws(function() {


Nit: While you're in here anyway, can you add a second argument to this assert.throws(), probably a RegExp that confirms that the error is the expected one?

Trott · 2016-12-08T22:45:11Z

test/parallel/test-tls-passphrase.js

@@ -11,11 +11,17 @@ var tls = require('tls');
 var fs = require('fs');
 var path = require('path');

-var key = fs.readFileSync(path.join(common.fixturesDir, 'pass-key.pem'));
+var passKey = fs.readFileSync(path.join(common.fixturesDir, 'pass-key.pem'));


Nit: While in here anyway, maybe take an opportunity to var->const some stuff? Up to you.

Trott · 2016-12-08T22:46:03Z

test/parallel/test-tls-no-cert-required.js

@@ -1,4 +1,5 @@
 'use strict';
+var assert = require('assert');


Nit: var->const in this file too if you are so inclined (and not if you are not).

mhdawson

LGTM subject to squashing and nits as pointed out by Rich.

Either the options or the listener argument to tls.createServer() was optional, but not both. This makes no sense, so align the argument checking and documentation with net.createServer(), which accepts the same option sequence, and which tls.createServer() is modelled on.

Its confusing to have multiple names for the same thing, use secureOptions consistently.

- All the secure context options are valid options to a secureContext - isServer modifies the default value of requestCert

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Either the options or the listener argument to tls.createServer() was optional, but not both. This makes no sense, so align the argument checking and documentation with net.createServer(), which accepts the same option sequence, and which tls.createServer() is modelled on. PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Its confusing to have multiple names for the same thing, use secureOptions consistently. PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Document all TLSSocket options: - All the secure context options are valid options to a secureContext - isServer modifies the default value of requestCert Describe all tls.connect() variants: - tls.connect(path) was undocumented - tls.connect(port) was underdocumented, and its relationship to tls.connect(options) was obscure Socket passed to tls.connect is user managed: - Replace #8996 Add documentation to: - describe and add tests for the pfx and key variants, and describe how and when passphrase is used. - describe tls cert and ca options - describe buffer forms of tls crl option - describe tls cipher option and defaults - fix link to Crypto Constants - describe that honorCipherOrder sets SSL_OP_CIPHER_SERVER_PREFERENCE. - describe tls ecdhCurve/dhparam options - describe tls secureProtocol option - describe tls secureOptions - describe tls sessionIdContext De-deduplicate secure context docs: The secure context options were documented 4 times, making it difficult to understand where the options come from, where they are supported, and under what conditions they are used. The multiple copies were inconsistent and contradictory in their descriptions of the options, and also inconsistent in whether the options would be documented at all. Cut through this gordian knot by linking all APIs that use the secureContext options to the single source of truth about the options. PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Either the options or the listener argument to tls.createServer() was optional, but not both. This makes no sense, so align the argument checking and documentation with net.createServer(), which accepts the same option sequence, and which tls.createServer() is modelled on. PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Its confusing to have multiple names for the same thing, use secureOptions consistently. PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

Document all TLSSocket options: - All the secure context options are valid options to a secureContext - isServer modifies the default value of requestCert Describe all tls.connect() variants: - tls.connect(path) was undocumented - tls.connect(port) was underdocumented, and its relationship to tls.connect(options) was obscure Socket passed to tls.connect is user managed: - Replace #8996 Add documentation to: - describe and add tests for the pfx and key variants, and describe how and when passphrase is used. - describe tls cert and ca options - describe buffer forms of tls crl option - describe tls cipher option and defaults - fix link to Crypto Constants - describe that honorCipherOrder sets SSL_OP_CIPHER_SERVER_PREFERENCE. - describe tls ecdhCurve/dhparam options - describe tls secureProtocol option - describe tls secureOptions - describe tls sessionIdContext De-deduplicate secure context docs: The secure context options were documented 4 times, making it difficult to understand where the options come from, where they are supported, and under what conditions they are used. The multiple copies were inconsistent and contradictory in their descriptions of the options, and also inconsistent in whether the options would be documented at all. Cut through this gordian knot by linking all APIs that use the secureContext options to the single source of truth about the options. PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Nov 25, 2016

sam-github changed the title ~~Improvements to~~ Improvements to tls API documentation, batch 1 Nov 25, 2016

sam-github added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Nov 25, 2016

sam-github commented Nov 25, 2016

View reviewed changes

sam-github force-pushed the notes-tls branch 2 times, most recently from dc2d08f to a05d3e8 Compare November 25, 2016 20:51

silverwind suggested changes Nov 25, 2016

View reviewed changes

Trott reviewed Nov 26, 2016

View reviewed changes

silverwind approved these changes Nov 30, 2016

View reviewed changes

sam-github commented Nov 30, 2016

View reviewed changes

sam-github force-pushed the notes-tls branch 2 times, most recently from 7c21a24 to 3c1b2e5 Compare December 8, 2016 21:45

Trott reviewed Dec 8, 2016

View reviewed changes

mhdawson approved these changes Dec 9, 2016

View reviewed changes

sam-github added 5 commits December 9, 2016 11:14

tls: fix/annotate connect arg comments

8ea758c

test: tls key/cert ordering not necessary

cd1fdfb

tls: do not refer to secureOptions as flags

28a3045

Its confusing to have multiple names for the same thing, use secureOptions consistently.

doc: document all TLSSocket options

53cfdb0

- All the secure context options are valid options to a secureContext - isServer modifies the default value of requestCert

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Jan 19, 2017

MylesBorins pushed a commit that referenced this pull request Jan 24, 2017

tls: fix/annotate connect arg comments

85fe05e

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins pushed a commit that referenced this pull request Jan 24, 2017

test: tls key/cert ordering not necessary

761ae95

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins pushed a commit that referenced this pull request Jan 24, 2017

test: var to const in tls-no-cert-required

75821ba

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins mentioned this pull request Jan 24, 2017

v6.10.0 proposal #10974

Merged

sam-github mentioned this pull request Jan 24, 2017

doc: add tls.DEFAULT_ECDH_CURVE #10264

Closed

2 tasks

sam-github added land-on-v4.x and removed dont-land-on-v4.x labels Jan 24, 2017

MylesBorins pushed a commit that referenced this pull request Jan 31, 2017

tls: fix/annotate connect arg comments

89db5fc

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins pushed a commit that referenced this pull request Jan 31, 2017

test: tls key/cert ordering not necessary

6b8d4ca

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins pushed a commit that referenced this pull request Jan 31, 2017

test: var to const in tls-no-cert-required

3f17c18

PR-URL: #9800 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

MylesBorins added dont-land-on-v4.x and removed lts-watch-v4.x labels Mar 9, 2017

Improvements to tls API documentation, batch 1 #9800

Improvements to tls API documentation, batch 1 #9800

Conversation

sam-github commented Nov 25, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

sam-github commented Nov 25, 2016

Choose a reason for hiding this comment

silverwind left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam-github Nov 25, 2016 • edited Loading

Choose a reason for hiding this comment

sam-github Nov 25, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam-github Nov 25, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

silverwind Nov 26, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam-github commented Nov 25, 2016

mscdex commented Nov 26, 2016

sam-github commented Nov 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sam-github commented Dec 8, 2016

mscdex commented Dec 8, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhdawson left a comment

Choose a reason for hiding this comment

sam-github commented Nov 25, 2016 •

edited

Loading

sam-github Nov 25, 2016 •

edited

Loading

sam-github Nov 25, 2016 •

edited

Loading

sam-github Nov 25, 2016 •

edited

Loading

silverwind Nov 26, 2016 •

edited

Loading