Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/util: move the case 'latin1' #9646

Closed
wants to merge 1 commit into from
Closed

internal/util: move the case 'latin1' #9646

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Nov 16, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

internal/util

Description of change

make the case 'latin1': near by case 'binary':.

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 16, 2016
@silverwind
Copy link
Contributor

Very minor, but would you care to swap lines 114 and 115 for consistency on what is the first case?

@JacksonTian
internal/util: move the case 'latin1'
7abf5eb 
make the `case 'latin1':` near by `case 'binary':`.
@targos
Copy link
Member

targos commented Nov 19, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4911/

jasnell pushed a commit that referenced this pull request Dec 5, 2016
@JacksonTian @jasnell
internal/util: move the case 'latin1'
fc31055 
make the `case 'latin1':` near by `case 'binary':`.

PR-URL: #9646
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Landed in fc31055.

@jasnell jasnell closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
@JacksonTian @Fishrock123
internal/util: move the case 'latin1'
f55a63c 
make the `case 'latin1':` near by `case 'binary':`.

PR-URL: #9646
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@JacksonTian
internal/util: move the case 'latin1'
4604b0d 
make the `case 'latin1':` near by `case 'binary':`.

PR-URL: nodejs#9646
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@JacksonTian @MylesBorins
internal/util: move the case 'latin1'
12fe071 
make the `case 'latin1':` near by `case 'binary':`.

PR-URL: #9646
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@JacksonTian @MylesBorins
internal/util: move the case 'latin1'
a6de84e 
make the `case 'latin1':` near by `case 'binary':`.

PR-URL: #9646
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JacksonTian @silverwind @targos @jasnell @lpinca @MylesBorins @nodejs-github-bot